JniImpl里调了另一个Jni如何处理？Jni call another jni exception.

aeskkkey commented 2 years ago

Jni impl calling another jni lead emulate error.

version

0.9.7-SNAPSHOT

example

A very simple app code as follow:

    static {
        System.loadLibrary("jni");
    }

    public static native void jniA(); // native call java()

    public static native void jniB();

    public static void java() {
        jniB();
    }

And the relate unidbg code:

vm.setJni(new AbstractJni() {
    @Override
    public void callStaticVoidMethodV(BaseVM vm, DvmClass dvmClass, String signature, VaList vaList) {
        if ("com/example/MyApplication->java()V".equals(signature)) {
            vm.resolveClass("com/example/MyApplication").callStaticJniMethod(emulator, "jniB()V");
            return;
        }
        throw new UnsupportedOperationException(signature);
    }
});
vm.resolveClass("com/example/MyApplication").callStaticJniMethod(emulator, "jniA()V");

error stack

call AbstractEmulator.emulate twice.

java.lang.IllegalStateException: running
    at com.github.unidbg.AbstractEmulator.emulate(AbstractEmulator.java:352)
    at com.github.unidbg.thread.Function32.run(Function32.java:39)
    at com.github.unidbg.thread.MainTask.dispatch(MainTask.java:19)
    at com.github.unidbg.thread.UniThreadDispatcher.run(UniThreadDispatcher.java:172)
    at com.github.unidbg.thread.UniThreadDispatcher.runMainForResult(UniThreadDispatcher.java:96)
    at com.github.unidbg.AbstractEmulator.runMainForResult(AbstractEmulator.java:340)
    at com.github.unidbg.arm.AbstractARMEmulator.eFunc(AbstractARMEmulator.java:229)
    at com.github.unidbg.Module.emulateFunction(Module.java:163)
    at com.github.unidbg.linux.android.dvm.DvmObject.callJniMethod(DvmObject.java:135)
    at com.github.unidbg.linux.android.dvm.DvmClass.callStaticJniMethod(DvmClass.java:260)
    at TestJni$1.callStaticVoidMethodV(TestJni.java:25)
    at com.github.unidbg.linux.android.dvm.AbstractJni.callStaticVoidMethodV(AbstractJni.java:607)
    at com.github.unidbg.linux.android.dvm.DvmMethod.callStaticVoidMethodV(DvmMethod.java:199)
    at com.github.unidbg.linux.android.dvm.DalvikVM$139.handle(DalvikVM.java:2197)
    at com.github.unidbg.linux.ARM32SyscallHandler.hook(ARM32SyscallHandler.java:132)
    at com.github.unidbg.arm.backend.UnicornBackend$11.hook(UnicornBackend.java:346)
    at unicorn.Unicorn$NewHook.onInterrupt(Unicorn.java:128)
    at unicorn.Unicorn.emu_start(Native Method)
    at com.github.unidbg.arm.backend.UnicornBackend.emu_start(UnicornBackend.java:377)
    at com.github.unidbg.AbstractEmulator.emulate(AbstractEmulator.java:380)
    at com.github.unidbg.thread.Function32.run(Function32.java:39)
    at com.github.unidbg.thread.MainTask.dispatch(MainTask.java:19)
    at com.github.unidbg.thread.UniThreadDispatcher.run(UniThreadDispatcher.java:172)
    at com.github.unidbg.thread.UniThreadDispatcher.runMainForResult(UniThreadDispatcher.java:96)
    at com.github.unidbg.AbstractEmulator.runMainForResult(AbstractEmulator.java:340)
    at com.github.unidbg.arm.AbstractARMEmulator.eFunc(AbstractARMEmulator.java:229)
    at com.github.unidbg.Module.emulateFunction(Module.java:163)
    at com.github.unidbg.linux.android.dvm.DvmObject.callJniMethod(DvmObject.java:135)
    at com.github.unidbg.linux.android.dvm.DvmClass.callStaticJniMethod(DvmClass.java:260)
    at TestJni.main(TestJni.java:31)

This will also lead to a ConcurrentModificationException of ArrayList.

[main]I/TEST: jni_0
Exception in thread "main" java.util.ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:909)
    at java.util.ArrayList$Itr.remove(ArrayList.java:873)
    at com.github.unidbg.thread.UniThreadDispatcher.run(UniThreadDispatcher.java:179)
    at com.github.unidbg.thread.UniThreadDispatcher.runMainForResult(UniThreadDispatcher.java:96)
    at com.github.unidbg.AbstractEmulator.runMainForResult(AbstractEmulator.java:340)
    at com.github.unidbg.arm.AbstractARMEmulator.eFunc(AbstractARMEmulator.java:229)
    at com.github.unidbg.Module.emulateFunction(Module.java:163)
    at com.github.unidbg.linux.android.dvm.DvmObject.callJniMethod(DvmObject.java:135)
    at com.github.unidbg.linux.android.dvm.DvmClass.callStaticJniMethod(DvmClass.java:260)
    at TestJni.main(TestJni.java:31)

reason

AbstractEmulator.emulate is syncing by running.

public final Number emulate(long begin, long until) throws PopContextException {
  if (running) {
    backend.emu_stop();
    throw new IllegalStateException("running");
  }
}

UniThreadDispatcher handle multi-thread tasks one by one within a list, but not solve the task-in-task case. Then the emulate running sync conflic.