search

zhmcclient / python-zhmcclient

A pure Python client library for the IBM Z HMC Web Services API
Apache License 2.0
38 stars 26 forks source link

Added support for running the 'ruff' checker #1531

Closed andy-maier closed 3 months ago

coveralls commented 3 months ago

Coverage Status

coverage: 80.169%. remained the same when pulling 2d28ec61dc995d5ca23f17155e456787a7ac4b99 on andy/ruff into f2c6cb88d1ab8f8f76638e29dfbdc1149570390f on master.

coveralls commented 3 months ago

Coverage Status

coverage: 80.169%. remained the same when pulling 1cce5312c272b0b207717e7bc8d67b46b44144ea on andy/ruff into f2c6cb88d1ab8f8f76638e29dfbdc1149570390f on master.

andy-maier commented 3 months ago

We already use flake8 and pylint, and now we add ruff. Ruff plans to replace flake8, but they are not yet there. Once ruff has reached the quality of flake8, we can drop the use of flake8. We cannot drop the use of pylint since it is the only tool that actually imports the modules which allows it to find errors that source code scanners (such as flake8 and ruff) cannot find.

The test workflow runs all of them (as does "make all"). So for a developer there is no choice when to use one vs the other: All of them need to pass, otherwise the PR cannot be merged. We already have pretty exhaustive text in our development section, so I'm not sure we should add even more words there that nobody reads.