Test: Transitioned to label 'no change log' for PRs without need for change log

zhmcclient / python-zhmcclient

A pure Python client library for the IBM Z HMC Web Services API

Apache License 2.0

39 stars 26 forks source link

Test: Transitioned to label 'no change log' for PRs without need for change log #1576

Closed andy-maier closed 4 months ago

andy-maier commented 4 months ago

For details, see the commit message.

Particular review points:

With this approach, the label needs to be set while creating the PR. If that is forgotten, the check fails and then after adding the label, a dummy push is needed to trigger the test workflow again. The question is, is that too cumbersome in the handling.

coveralls commented 4 months ago

coverage: 82.364%. remained the same when pulling d9f3bddd0c3769b5c3f4b76a925ad1f4a51546bf on andy/ease-changelog-checking into 6c70b19114cb6a731acbb31903701c9461fc7a86 on master.

andy-maier commented 4 months ago

Then let's discuss in our next meeting.

coveralls commented 4 months ago

coverage: 82.581%. remained the same when pulling 2bfa10c168271b35d79819b3fe35f54adb43625f on andy/ease-changelog-checking into 9bdf888aad6289d170780c893cfcf92c055ed92c on master.

coveralls commented 4 months ago

coverage: 82.549%. remained the same when pulling 83d1a69bba568448026f32b88685ec0780c95457 on andy/ease-changelog-checking into a7649eea637ab95c885a567fc97f64654e1d7a87 on master.

andy-maier commented 4 months ago

We discussed the check for fragment files, and decided to remove the entire check, because it creates too much overhead. Missing change log entries then will need to be discovered during review, as it was before we introduced change fragment files.