Added support for HTTPS and mutual TLS (mTLS)

zhmcclient / zhmc-prometheus-exporter

A Prometheus exporter for the IBM Z HMC

Apache License 2.0

14 stars 9 forks source link

Added support for HTTPS and mutual TLS (mTLS) #361

Closed andy-maier closed 9 months ago

andy-maier commented 1 year ago

For details, see the commit message, or invoke with --help-creds.

This PR currently uses the prometheus-client package from its master branch.

Charles1000Chen commented 1 year ago

@andy-maier In our use case, we wanna configure the mTLS related parameters in zhmc exporter's credential yaml. Could you implement loading the mTLS parameters from credential yaml like below:

tls_server_config:
    ca_cert: ca.crt
    server_cert: server.crt
    server_key: server.key

This way/configuration is our other exporters are using. Thanks.

andy-maier commented 1 year ago

@Charles1000Chen I agree this is the better solution. DONE.

andy-maier commented 9 months ago

I updated the PR to use the prometheus-client package from its master branch, now that PR https://github.com/prometheus/client_python/pull/946 has been merged.

coveralls commented 9 months ago

coverage: 37.671% (-1.4%) from 39.074% when pulling 4f6d9369b1694b876163517a1aba8ed0a2e48c8d on andy/https-support into 722fc1577c9322b787295891f88eb8a768002162 on master.