search

zhmcclient / zhmc-prometheus-exporter

A Prometheus exporter for the IBM Z HMC
Apache License 2.0
12 stars 8 forks source link

Fixed warning about ignoring label 'adapter/port' #457

Closed andy-maier closed 4 months ago

andy-maier commented 4 months ago

For details, see the commit message.

Tested the change on the HMC of A224. However, I could not reproduce the new log message when adding NICs.

Also, in tests on dal12z1.CPCB where the problem originally was observed on partition dal2-qz2-sr2-rk070-m09 it could not be reproduced. We ran the old exporter and an exporter with the code from this PR in parallel for 2 days, but creating NICs did not trigger the situation.

Even though we don't understand yet what triggers the situation, the change in this PR handles the situation definitely better than before, soI think we should go ahead with the PR.

coveralls commented 4 months ago

Coverage Status

coverage: 35.918% (-0.9%) from 36.776% when pulling 7114ff0246407ec3ff5e505948a92e713dfc392c on andy/fix-label-ignore-warning-adapter-port into 3f7345322dc502c0618245c81cd2878086bff47c on master.