search

zhmcclient / zhmc-prometheus-exporter

A Prometheus exporter for the IBM Z HMC
Apache License 2.0
11 stars 8 forks source link

Use minimum versions for safety run on dependencies for install #489

Closed andy-maier closed 3 months ago

andy-maier commented 3 months ago

The safety runs had already been split in an earlier PR between "install" and "all". However, the requirements.txt file is now used for install, and that causes safety to pass even when the minimum version has a safety issue. It would only fail is there was a pinning to a version that has safety issues.

This ticket is to improve that by moving the direct and indirect install dependencies in the minimum-constraints.txt file into a new minimum-constraints-install.txt file for use by the safety run for install. The new file would be includes with -c in the existing file.

andy-maier commented 3 months ago

Addressed in commit 8d8ab7c (by mistake without a PR).