search

zhmcclient / zhmccli

A CLI for the IBM Z HMC
Apache License 2.0
10 stars 9 forks source link

Support for reset/image/load activation profiles #499

Closed andy-maier closed 1 year ago

andy-maier commented 1 year ago

Ready for review. Has been tested on A65. To try this PR yourself, run make install after checking out the branch, in order to install the updated "zhmcclient" package.

coveralls commented 1 year ago

Coverage Status

coverage: 36.876% (+2.5%) from 34.352% when pulling 8222faec8cca7c5435ec5b0530d61ec7d482bdbf on andy/add-activation-profiles into 4d5d7a5296de26793da5cab2c74e48206d78d853 on master.

andy-maier commented 1 year ago

I have introduced helper functions for the setting of properties from specially handled options. Please re-review.

andy-maier commented 1 year ago

I looked again at the find_...() functions and whether they take cpc_name or cpc_or_name as an argument. All of them take cpc_or_name as an argument, except the three new ones for the activation profiles. But none of them uses the ability for Cpc as a resource object, it was just passed through, but never actually called that way.

So we could remove the support for a Cpc resource object in the find_:::() functions and reduce that to just always the CPC name. That would eliminate some other portions of duplicated code.

I'll do that in a separate PR.

Update: That became PR #525