search

zhongwencool / maxwell

Maxwell is an HTTP client which support for middleware and multiple adapters.
MIT License
110 stars 17 forks source link

Multipart.add_file_content_with_name (issue #69) #71

Closed visciang closed 7 years ago

visciang commented 7 years ago

This PR extend Multipart functions with:

Those are a variation on Multipart.add_file and * Multipart.add_file_with_name. They accept the file_content binary in place of file_path.

Note Multipart was strictly based on hackney multipart implementation and so the {:multipart, multiparts} request body form was fully compatible with :hackney.request.

With this extension we diverge from hackney breaking the request body compatibility. This is the reason why I changed Maxwell.Adapter.Hackney.send_multipart callback to use a Util.multipart_encode.

Another option is to open a PR to hackney in the same direct of this one.

In my opinion, given that only hackney natively support multipart body, it's better to use for all the adapter the Maxwell multipart encoder. It is consistent among all adapter library and easier to maintain.

If you agree with me, a further improvement could be refactoring out send_multipart callback from all the adapters and call Util.multipart_encode in adapter.ex call before passing down to send_direct (as I did in this PR for hackney). Let me know.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 98.623% when pulling 4aef0ea65ca0f01336ffa83f3658df2fe1cad844 on visciang:multipart_file_content into cb3b16383dd1692662bc80baa07a512aab733cf7 on zhongwencool:master.