permit http delete request with body

zhongwencool / maxwell

Maxwell is an HTTP client which support for middleware and multiple adapters.

MIT License

110 stars 17 forks source link

permit http delete request with body #73

Closed milkwine closed 6 years ago

milkwine commented 6 years ago

Try to fix #64 @secretworry , any suggestions? I may have time to work on it recently.

coveralls commented 6 years ago

Coverage remained the same at 98.584% when pulling 2cbed44ffcea0a98a80fe50094041dbe5ba5cc07 on milkwine:master into 030a822e4a96836074af750a39792ced9cf1b12e on zhongwencool:master.

zhongwencool commented 6 years ago

Thanks 👍 I'm curious about why test case failed on R18.

milkwine commented 6 years ago

R18 httpc seems not support delete with body. https://github.com/erlang/otp/commit/0526f1a5a545d2e6be0b5ef4f2588ed81447c416#diff-89dd40e56844b997ffa9a9d90d59d5fc

milkwine commented 6 years ago

Hi @zhongwencool, CI should be passed when you restart it. Should this commit be considered?

zhongwencool commented 6 years ago

Release tomorrow ：）