search

zhongwencool / maxwell

Maxwell is an HTTP client which support for middleware and multiple adapters.
MIT License
110 stars 17 forks source link

Support Mint #75

Open falood opened 5 years ago

falood commented 5 years ago

https://hex.pm/packages/mint

secretworry commented 5 years ago

Hi, @falood I just gave the mint a skim. A very cool HTTP lib having a very straightforward implementation with leaving connection management to the user.

Maxwell made an assumption that all request methods have side-effects managing an implicit connection pool. , so that Maxwell doesn't incur any connect and close actions.

The assumption doesn't apply to mint, so we might need to invent a new concept, a connection pool manager adapter. And that requires more adaptations. @zhongwencool We might need a discussion over this.

secretworry commented 5 years ago

Just noticed mint is considering pooling their connections ericmj/mint#32. We just need to wait for the enhancement's debut.