"Convert to group chat" creates illegal default room name

zhongxan / emite

Automatically exported from code.google.com/p/emite

0 stars 0 forks source link

"Convert to group chat" creates illegal default room name #222

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

If you convert to group chat a one-to-one chat, the default room name may be 
illegal if the usernames have illegal characters, in particular the 
underscore.
Moreover, no error is displayed. If you confirm the creation, a new tab 
appears but completely empty.

Attached a patch that sanitizes the room name before the display.

Original issue reported on code.google.com by antonio....@gmail.com on 23 Mar 2010 at 3:35

Attachments:

hablar-roomname-bug.diff

GoogleCodeExporter commented 8 years ago

Thanks a lot!!! I will apply it soon.

Original comment by danigb on 24 Mar 2010 at 3:45

Changed state: Accepted
Added labels: Component-Hablar

GoogleCodeExporter commented 8 years ago

This issue was closed by revision r1391.

Original comment by danigb on 24 Mar 2010 at 3:55

Changed state: Fixed