search

zhooravell / skrill-php-client

Skrill api php wrapper
MIT License
17 stars 16 forks source link

Consider integrating the PHP_CodeSniffer to check PSR-12 coding style #8

Open peter279k opened 4 years ago

peter279k commented 4 years ago

As title, after looking at some of commits for this repository, it seems that this PHP package uses the PSR-12 coding style.

To let the coding style checking be automatic, I think it's nice to define the PHP_CodeSniffer inside require-dev block on composer.json file.

And adding the php vendor/bin/phpcs src/ tests/ --standard=psr12 during Travis CI building.

Once @zhooravell accepts this issue, I'll be happy to work on this :).

zhooravell commented 4 years ago

@peter279k, This is a good idea.

darkos82 commented 2 years ago

Hi guys, this is a good project, because in php not existing anyone (by my research), it's complete? Can i implement into my website (after create skrill account and after convert it in testing) for a direct payment with ipn (or webhook?) notifications? thanks so much L.

zhooravell commented 2 years ago

Hi! This library does not have an ipn implementation

darkos82 commented 2 years ago

Excuse me, i meant the 'status_url' param

zhooravell commented 2 years ago

https://github.com/zhooravell/skrill-php-client/blob/master/src/Request/SaleRequest.php#L113

darkos82 commented 2 years ago

Ok thanks! I've a curiosity, why in example main you not set this param? Best regards

zhooravell commented 2 years ago

Because this is just an example. For more details please see tests https://github.com/zhooravell/skrill-php-client/blob/master/tests/Request/SaleRequestTest.php#L37

darkos82 commented 2 years ago

okk thanks for all! Have nice day Bro!