zhouhan0126 / WIFIMANAGER-ESP32

wifimanager-esp32
MIT License
402 stars 137 forks source link

Bug fix for https://github.com/zhouhan0126/WIFIMANAGER-ESP32/issues/1… #3

Open LaurentLouf opened 6 years ago

LaurentLouf commented 6 years ago

… : disconnect the AP before trying to connect in STA mode.

Well that's pretty much self-explanatory : I investigated a bit and found quite strange that before trying to connect to an AP we don't turn off the AP created by WiFiManager. @zhouhan0126 I also created a fork of arduino-esp32 that fixes a problem with DNS Server (which is now integrated in the repository) and with both forks, I have a working WiFiManager (self portal works great and it connects to the AP when saving the credentials).

LaurentLouf commented 6 years ago

I've added some commits that add some possibilities : add labels to the form when adding parameters, get parameters from the WiFiManager object and most importantly fix a tiny bug, especially annoying for parameters of length 1 since the store operation did not take into account the extra-byte necessary for the null character at the end of the string.