search

zhouqingqing / qpmodel

A Relational Optimizer and Executor
MIT License
66 stars 18 forks source link

change Exec()/Close() codegen to use ExecContext.code_ #125 #171

Closed zhouruiapple closed 4 years ago

zhouruiapple commented 4 years ago

fix issues from code factor. generate code to @context.code_ directlly. change the paramter of Exec from Func to Action. all Exec() of query plans do not return generated code.

zhouqingqing commented 4 years ago

Good job thanks!

  1. please fix codefactor 4 issues;
  2. please investigate why coverage drops 0.4%.
zhouruiapple commented 4 years ago

The code coverage rate decreases due to the following two reasons:

  1. Brackets are added to the conditional branches of a single line. For example https://coveralls.io/builds/32545682/source?filename=qpmodel%2FPhysicalNode.cs#L356.
  2. Move the code of codegenif to caller to generate code to @context.code. For example https://coveralls.io/builds/32545682/source?filename=qpmodel%2FPhysicalNode.cs#L612.

we need to add test case to cover above code in the feature. @zhouqingqing

zhouqingqing commented 4 years ago

The code coverage rate decreases due to the following two reasons:

That's ok - as long as we understand the reasons.