search

zhouzhuojie / meteor-vue

Vue for Meteor
130 stars 8 forks source link

Remove CoffeeScript and replace with JavaScript #15

Closed codebryo closed 9 years ago

codebryo commented 9 years ago

Replaced the main.js file. Tried to simplify it as much as possible.

zhouzhuojie commented 9 years ago

Thanks so much for the pr. Can you take a look at the error from CI? https://travis-ci.org/zhouzhuojie/meteor-vue/builds/84561317

codebryo commented 9 years ago

Is there a way to let the tests run locally? It tells me it's missing a make file :/

codebryo commented 9 years ago

@zhouzhuojie hey there, can you help me to make those 2 open PR's work? Now as vue approaches v1.0 and it has a lot of major changes we should try to get this up to date. Would still need some help on the test if I can somehow run it locally for better debugging

codebryo commented 9 years ago

The recent changes I did makes the test fall at the same point where the other PR fails. As I have no experience with Meteor Package development I am not sure what I'm missing on the testing.

codebryo commented 9 years ago

I made progress on having the tests run locally. Worked with meteor test-packages ./ Although I get now the same errors as online I am not sure why tests don't pass. For some reasons Vue is not available in the meteor app where the tests are run. Some help would be appreciated.

nerijunior commented 9 years ago

+1