search

zhouzi / GentleForm

Accessible and user-friendly HTML5 form validation library.
http://codepen.io/Zhouzi/full/QbBzZp/
MIT License
36 stars 3 forks source link

Almost usefull but... #12

Open DimaGashko opened 5 years ago

DimaGashko commented 5 years ago

image

I do not think that's correct. Also validation behavior a little bit unexpectable.

It's almost what i'm serching for, but...

zhouzi commented 5 years ago

Hmmm, that's quite unexpected. How was the input filled? Was it filled with a password manager/autocomplete or did you type it? What browser are you using?

I tried a few things but I am unable to reproduce it 😕

Also, could you elaborate on "validation behavior a little bit unexpectable" please? I'm always happy to receive feedback! 👍

DimaGashko commented 5 years ago

Hi, thank you for your response.

Firstly email validation is definitly incorrect:

image

But that error, strangely, i can reproduce only by using screen reader (ChromeVox in my case).

https://drive.google.com/file/d/1iBq2spO8qWKCSlpGbXaqbS6LrwhGag3F/view?usp=sharing

"validation behavior a little bit unexpectable"

In 2019 I expect it like here:

https://baianat.github.io/vee-validate/examples/

But, now i think your variant is completle ok.

p.s. I use Chrome (Ubuntu)

DimaGashko commented 5 years ago

If you fix that, your solution will be the best of vanillaJS form validation!

zhouzi commented 5 years ago

Thanks for the recording @DimaGashko 👍 I will have to give a try to ChromeVox to understand what is going wrong.

Regarding the email pattern, it relies on the browser's which follows the official specification that says email@domain are valid emails. According to that specification, emails can get pretty crazy. I agree that most of the time you would rather protect your app from this kind of email. The thing is that GentleForm's purpose is to rely on browser validation so I'm afraid there's not much we can do about that.