Open zhoyx opened 1 year ago
We disagree with the characterization of a duplicate person. For example, van Gogh and Van Gogh can refer to 2 different people. We do not want to narrow the scope of a duplicate person to such a degree and rather leave it to the user to decide.
Team chose [response.Rejected
]
Reason for disagreement:
As stated in the CS2103T website, bugs relating to duplicate detection are valid Feature flaws. I feel that differentiation based on capitalization do not represent how names are treated in the real world as names tend not to be differentiate by capitalization unless you are possible refering to a historic figure as stated in your example. In actual use of the application, it is likely that the names John Doe
and John doe
refers to the same person. A better way to add an additional layer of duplicate checking would be through possibly also comparing their Emails and phone numbers which tend to uniquely identify users. Thus I believe that the current implementation would likely cause more issues(inclusion of duplications) compared to the limited additional value created in the unlikely scenerio that capitalization is an actual intended differentiating factor by the user rather than an accidental duplicate entry.
Furthermore, the documentation in the User guide does not state the assumption the team is making with regards to duplicate detection. This would lead users to think that duplicate entries are being detected when in actual fact it is not.
Steps to reproduce: Assumption: the list of patients are empty
Add a new patient with the name John Doe
add-ptn n/John Doe p/98765432 e/jdoe@gmail.com h/1.85 w/70.5 d/Fever st/Outpatient r/No known allergies t/pendingReview
Add another patient with the name john Doe with "j" not capitalized and all other data the same
add-ptn n/john Doe p/98765432 e/jdoe@gmail.com h/1.85 w/70.5 d/Fever st/Outpatient r/No known allergies t/pendingReview
Expected result:
Actual result:
Screenshots: