Suggestion : Drawable indicator is not a part of Library..

zhpanvip / viewpagerindicator

🔥 Worked with ViewPager and ViewPager2,support multiple slider styles and multiple slide mode.This repo was split from BannerViewPager-

https://github.com/zhpanvip/BannerViewPager

Apache License 2.0

712 stars 59 forks source link

Suggestion : Drawable indicator is not a part of Library.. #18

Closed iamAliRaza closed 3 years ago

iamAliRaza commented 3 years ago

You should add Drawable Indicator inside library...

Thanks

zhpanvip commented 3 years ago

You need copy DrawableIndicator from sample code. https://github.com/zhpanvip/viewpagerindicator/blob/master/app/src/main/java/com/zhpan/viewpagerindicator/DrawableIndicator.kt

iamAliRaza commented 3 years ago

Yup .. I copied already but i was thinking it would be a part of library .... So that;s why i posted here as a suggestion that if you would add these helpers classes as a part of library so it would be easy for developers ...

zhpanvip commented 3 years ago

Thanks for your suggstion. This library mainly provides indicators of different styles and different sliding modes as shown in homepage table. Also ,it provides good extension funtions,you can implement any style you want by custom indicator easily. DrawableIndicator is only one of these custom indicators,but not the part of this library.So Ithink It will not be added in library. if need,just copied DrawableIndicator from sample or customized yourself indicator by extends BaseIndicatorView.

iamAliRaza commented 3 years ago

ok thanks Up to you 👍🏻