search

zhrexl / DrawOnYourScreen2

GNU General Public License v3.0
209 stars 20 forks source link

[BUG] Not receiving touch event #22

Open michalmielczynski opened 1 year ago

michalmielczynski commented 1 year ago

Hey, I've seen a short note in README.md that touch support is ... planned? Any chance to know if/when this can be implemented. I'm looking myself into the code but this is completely new field - I don't even know where to start.

zhrexl commented 1 year ago

Touch works. The issue is that you can't open or exit the extension by touch you'll need the keyboard as it is toggled by shortcuts.

I've been thinking about a button in quick settings (Shell >43) but as I don't have a touch screen to try it i can't be sure if its the best option. Any thoughts?

michalmielczynski commented 1 year ago

hm, I'm not sure if I understand what you've said. I can normally open/enter the extension with Super+Alt+D key, draw using mouse or touchpad, but not using the touchscreen. Maybe I should be more specific in first post - extension works great except when I'm trying to draw with my finger (on touchscreen).

zhrexl commented 1 year ago

I can normally open/enter the extension with Super+Alt+D key, draw using mouse or touchpad, but not using the touchscreen.

ok, i was led to believe that touch was working fine. I'll review that part of the code to see if I can get to the root cause of it next week. Thanks for your report.

michalmielczynski commented 1 year ago

that would be fantastic. I've found the touch branches here, but honestly I'm not able to perform any changes/tests, as my knowledge of Gnome extension development is very limited.

michalmielczynski commented 1 year ago

ok, if that's any of help, I was testing the extension with nested gnome-shell session, and it works there fine. The problem is that on 'native' gnome-shell touch event is not working.

I'm running nested shell with this command: env GNOME_SHELL_SLOWDOWN_FACTOR=2 MUTTER_DEBUG_DUMMY_MODE_SPECS=1440x900 dbus-run-session -- gnome-shell --ne

zhrexl commented 1 year ago

ok, if that's any of help, I was testing the extension with nested gnome-shell session, and it works there fine. The problem is that on 'native' gnome-shell touch event is not working.

The nested session is usually wayland. The 'native' session is wayland or x11?

michalmielczynski commented 1 year ago

yes, all Wayland.

mlo-poc commented 1 year ago

may I add, that any sort of activation without the need of a keyboard would be great.