Closed aabrame closed 9 months ago
This is great! but there are small problems The settings of extension draw-on-your-screen2@zhrexl.github.com had an error:
Error: GSettings key quicktoggle-disabled not found in schema org.gnome.shell.extensions.draw-on-your-screen
Stack trace:
_init/Gio.SettingsSchema.prototype.get_key@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:721:19
Preferences/<@file:///home/stas/.local/share/gnome-shell/extensions/draw-on-your-screen2@zhrexl.github.com/ui/preferencespage.js:68:45
Preferences@file:///home/stas/.local/share/gnome-shell/extensions/draw-on-your-screen2@zhrexl.github.com/ui/preferencespage.js:65:43
fillPreferencesWindow@file:///home/stas/.local/share/gnome-shell/extensions/draw-on-your-screen2@zhrexl.github.com/prefs.js:38:21
_loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:36:18
async*_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:21:14
ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:12:4
OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33
async*_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34
maybe I do a mistake somewhere
@ruvsv I can't reproduce your error. Can you describe the steps you've followed ?
The schema indeed include a quicktoggle-disabled
entry. I don't see why it would be missing in the settings.
I have tested around a bit though i mostly use only basic features but anything ive tried has worked with no issues edeavouros arch
The last commit corrects a bug causing an error when disabling the extension.
@aabrame tested and LGTM, thanks!
Here is an adaptation of the extension for gnome 45. The main changes I've performed are:
ExtensionUtils
and replacing a lot of global variables by passing the extension object in the constructorAll seems to be working, but I didn't perform exhaustive checks. Note that it is not compatible with previous gnome version.