Add gnome-shell 43 compatibility

[somethingGoneWrong]

Hi, can you add gnome 42 compatibility? thx

[camandel]

It works on Gnome 42. You just need to add the new version in metadata.js I opened PR #7

[zhrexl]

It works on Gnome 42. You just need to add the new version in metadata.js I opened PR #7

I fear thats not enough. Gnome shell 42 doesn't have a OsdWindowConstraint anymore.

[sp1ritCS]

I fear thats not enough. Gnome shell 42 doesn't have a OsdWindowConstraint anymore.

the base functionally seems to work. It's just things like the window styles that have changed likely due to the switch to libadwaita. Also GNOME42 new screenshot ui doesn't work with DOYS, as the extensions prevent pressing the button to take a screenshot :/

[zhrexl]

I fear thats not enough. Gnome shell 42 doesn't have a OsdWindowConstraint anymore.

the base functionally seems to work. It's just things like the window styles that have changed likely due to the switch to libadwaita. Also GNOME42 new screenshot ui doesn't work with DOYS, as the extensions prevent pressing the button to take a screenshot :/

libadwaita is not a problem, as this extensions uses gtk4 it should not have any compatibility problems. The preference window still works. The screenshot api has changed in gnome and I'll update it. Sadly I'm not finding any documentation about OsdWindows which is making porting this extension a bit harder. Hope to get it done as soon as possible.

[sp1ritCS]

libadwaita is not a problem, as this extensions uses gtk4 it should not have any compatibility problems. The preference window still works.

it still works, but at least for me there are styling issues with the ListBox(Row)s, which look like they are libadwaitas fault

[Julientroploin]

It works on Gnome 42. You just need to add the new version in metadata.js I opened PR #7

I tried this and extension can still not be activated, I get this message in GNOME Extensions after logout/login : "class heritage OsdWindow.OsdWindowConstraint is not an object or null"

My metadata.json file : { "_generated": "Generated by SweetTooth, do not edit", "data-dir": "draw-on-your-screen", "description": "Start drawing with Super+Alt+D and save your beautiful work by taking a screenshot", "gettext-domain": "draw-on-your-screen", "name": "Draw On Your Screen 2", "persistent-file-name": "persistent", "settings-schema": "org.gnome.shell.extensions.draw-on-your-screen", "shell-version": [ "40", "41", "42" ], "svg-file-name": "DrawOnYourScreen", "url": "https://github.com/zhrexl/DrawOnYourScreen2", "uuid": "draw-on-your-screen2@zhrexl.github.com", "version": 1 }

[rodrix]

Hello guys, any news about this? Thanks!

[zhrexl]

Hello guys, any news about this? Thanks!

I've been quite busy this last few weeks writing my thesis. I dont know if I'll be able to work on it before May 20. Sorry for this guys. I am accepting PRs. I'll be working on it after May 20.

[keithvassallomt]

For those of you desperate to get this working (like me), I've uploaded a version here which should work on Gnome 42. Note that this is Absolutely NOT a solution to the problem in this thread. This simply edits metadata.json to specify Gnome 42 compatibility, and disables the code which causes the 'OsdWindowConstraint' error when trying to enable the extension.

I will not be submitting a PR since this doesn't solve the problem, it simply ignores it. Maybe this can tide you over until @zhrexl can fix it properly.

Huge thank you to @zhrexl for forking this extension!

[keithvassallomt]

For those of you desperate to get this working (like me), I've uploaded a version here which should work on Gnome 42. Note that this is Absolutely NOT a solution to the problem in this thread. This simply edits metadata.json to specify Gnome 42 compatibility, and disables the code which causes the 'OsdWindowConstraint' error when trying to enable the extension.

I will not be submitting a PR since this doesn't solve the problem, it simply ignores it. Maybe this can tide you over until @zhrexl can fix it properly.

Huge thank you to @zhrexl for forking this extension!

I also noticed that after leaving drawing mode, my keyboard shortcuts (CTRL, META and so on) were not working. I've made another change which seems to fix the issue, and have updated the download above.

[daveprowse]

Hello guys, any news about this? Thanks!

I've been quite busy this last few weeks writing my thesis. I dont know if I'll be able to work on it before May 20. Sorry for this guys. I am accepting PRs. I'll be working on it after May 20.

Good luck on your thesis! And thank you for spending the time updating this tool. It is the only serious annotating tool for Linux that I know of. Let us know if there's anything you need while working on this project.

[zhrexl]

For those of you desperate to get this working (like me), I've uploaded a version here which should work on Gnome 42. Note that this is Absolutely NOT a solution to the problem in this thread. This simply edits metadata.json to specify Gnome 42 compatibility, and disables the code which causes the 'OsdWindowConstraint' error when trying to enable the extension. I will not be submitting a PR since this doesn't solve the problem, it simply ignores it. Maybe this can tide you over until @zhrexl can fix it properly. Huge thank you to @zhrexl for forking this extension!

I also noticed that after leaving drawing mode, my keyboard shortcuts (CTRL, META and so on) were not working. I've made another change which seems to fix the issue, and have updated the download above.

Thanks for your contribution!

There was a change in Main.js done by the gnome team that is affecting this extension. I'm working on it. Hope to get a new release soon, thanks guys!

[sakshamprakash01]

@zhrexl did you find any solution?

[zhrexl]

@zhrexl did you find any solution?

Yep. The latest commit (from 6 days ago) works on GNOME 42 and can be used sorry not to update you guys. The settings page is not right though. I'll rewrite so it follows LibAdwaita theme. Thats the reason I didnt make a new release. A half done extension is not good enough for a release. Hope to get it(preferences page) done in the next 3~2 days. I'll then do a full review and clean up in the code.

Users should download and manually install the extension from the GNOMEv42 branch until I finish rewriting preferences page. https://github.com/zhrexl/DrawOnYourScreen2/tree/GNOMEv42

[aborrell]

Hi, I'd follow the instructions here but it does not work. I'm running debian Sid with gnome-shell 42.2. When I open the extensions panel it says draw version is not compatble with gnome, I added "42" in metadata.json, and I've got the following error: class heritage OsdWindows:OsdWindowConstraint is not an object or null

Thanks

[CodexHere]

Hey @zhrexl thanks for working on this, but it's been almost a month without an update when you mentioned a few days turnaround time.... Curious if you could give an update? I love this extention and feel naked without it!

[zhrexl]

Hey @zhrexl thanks for working on this, but it's been almost a month without an update when you mentioned a few days turnaround time.... Curious if you could give an update? I love this extention and feel naked without it!

The extenstion is working. You can and should use the GNOME v42 branch version of this extension (and manually install it).

To upload this extension on GNOME Extension, I'll have to (as required by them):
1. Rewrite UI in prefs.js/menu.js/Extension.js [Not finished yet];

2. Remove all locale/POTFILES.in, .po and .pot files;

3. Use initTranslations() and getSettings() from ExtensionUtils;

4. Prefs won't load up in 40 and 41 because of Adw import in prefs.js (I'll probably remove support for GNOME Shell < 42);

5. Remove gtk3 dependency;

6. Mention in the description that its a forked extension;

I ended up getting really busy and couldnt finish the necessary changes to upload it to GNOME Extension.

[aborrell]

Well, with the 42vbranch is working perfectly, thanks for a very useful software

[7system7]

:partying_face: :confetti_ball:

[xdnroot]

Ubuntu 22.04 GNOME 42.2

Last month, this extension works well. However today, it cannot be enabled. Is it something wrong with my machine or there is bug on this extension?

[xdnroot]

For those of you desperate to get this working (like me), I've uploaded a version here which should work on Gnome 42. Note that this is Absolutely NOT a solution to the problem in this thread. This simply edits metadata.json to specify Gnome 42 compatibility, and disables the code which causes the 'OsdWindowConstraint' error when trying to enable the extension.

I will not be submitting a PR since this doesn't solve the problem, it simply ignores it. Maybe this can tide you over until @zhrexl can fix it properly.

Huge thank you to @zhrexl for forking this extension!

Your shared file solved my problem, thanks.

[JaldeaR]

For Gnome 42 for issue class heritage OsdWindow.OsdWindowConstraint is not an object or null use: https://github.com/zhrexl/DrawOnYourScreen2/tree/GNOMEv42

[zhrexl]

I'll close this issue as soon as GNOME v43 support is added. While this doesnt happen I'd like to ask for your help testing the libadwaita (ONLY GNOME SHELL >= 42) branch.

I'd really appreciate your feedback, design and feature requests!

This updated version will be available on GNOME Extensions.

Thanks!

[zhrexl]

PR #17 closes this issue. The extension was accepted at GNOME extensions.