search

zhuangdizhu / FedGen

Code and data accompanying the FedGen paper
233 stars 68 forks source link

Noise generation in generator.py (line 63) #10

Open gwmdunda opened 2 years ago

gwmdunda commented 2 years ago

It seems that torch.rand generates [0,1) uniformly based on the official documentation instead of standard Gaussian. Is this intended? Thanks

zhuangdizhu commented 2 years ago

It seems that torch.rand generates [0,1) uniformly based on the official documentation instead of standard Gaussian. Is this intended? Thanks

Thanks for the nice catch. We did not realize this mismatch between the paper and code. The noise should be sampled from uniform[0, 1) instead of N(0, I) as described in the paper. Sorry for the confusion.