search

zhujingguang / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

ASSERT() in fpdfsdk/src/javascript/*.cpp files doesn't assert on linux / debug builds #136

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Noticed once a win / debug bot was added to the waterfall. See 
http://build.chromium.org/p/client.pdfium/builders/win/builds/7/steps/javascript
%20tests/logs/stdio for an example of where win asserts but linux blindly 
succeeds.

We should make this consistent on all platforms, probably want to abandon 
ASSERT() and use FXSYS_Assert() or some such as consistent through the rest of 
the pdfium code base (or the other way around).

Original issue reported on code.google.com by tsepez@chromium.org on 27 Mar 2015 at 4:02