search

zhuker / lamejs

mp3 encoder in javascript
Other
820 stars 200 forks source link

MPEGMode is not defined #89

Open Selithrarion opened 2 years ago

Selithrarion commented 2 years ago

please reopen #86, still have the same problem v1.2.1 vue 3 to reproduce - https://github.com/Selithrarion/quasar-nest_audio-tools

isolin commented 2 years ago

This is a temporary solution: https://github.com/zhuker/lamejs/issues/91#issuecomment-1146587589

cbroad commented 2 years ago

The code works as written... in the repository. What needs to be done is it needs to be pushed out to npm. It was fixed in January, but here we are in August, still using the broken published version from December.

In the meantime, here's what I did to fix it. Instead of this line in your package.json "lamejs": "^1.2.1", point to the github repo "lamejs": "zhuker/lamejs",

I'd prefer to only use what's in NPM, but it doesn't work at the moment.

sempostma commented 2 years ago

If you are using webpack, a temporary fix is to import using exports-loader like this: import lamejs from 'exports-loader?exports=default|lamejs!lamejs/lame.min.js'

yanickrochon commented 1 year ago

@zhuker could you publish to npm so we can rely on the actual project? Thanks.

scottoasis commented 1 year ago

The code works as written... in the repository. What needs to be done is it needs to be pushed out to npm. It was fixed in January, but here we are in August, still using the broken published version from December.

In the meantime, here's what I did to fix it. Instead of this line in your package.json "lamejs": "^1.2.1", point to the github repo "lamejs": "zhuker/lamejs",

I'd prefer to only use what's in NPM, but it doesn't work at the moment.

Now we are at September 2023 and the issue is still there in the latest NPM package.