zhukov / webogram

Telegram web application, GPL v3
https://web.telegram.org
GNU General Public License v3.0
7.94k stars 2.36k forks source link

Unread badge favicon #2045

Open HaydenBL opened 3 years ago

HaydenBL commented 3 years ago

I recently started using Telegram, and it's pretty good but I was getting a bit frustrated with the unread favicon indicator in the webapp. Most other chat webapps I use make it a little more obvious when you have a notification, whereas Telegram just has a mail icon with the same color scheme.

I did some Googling and found I was not the only one with this problem:

https://github.com/zhukov/webogram/issues/1585
https://github.com/zhukov/webogram/issues/1718

So this PR hopefully solves this issue! I was originally just gonna make it a red dot, but I saw in the one issue someone mentioned adding a count to the badge, so I figured I might as well do that while I'm messing around here.

Here's a picture of what it looks like in a tab:

Screen Shot 2021-01-11 at 8 19 22 PM

Let me know if something needs fixing!

HaydenBL commented 3 years ago

Actually now that I'm actually taking time to read the gulpfile I'm thinking I might not need to add that since it just puts those files into the top level when you build. I'll await confirmation on whether or not I need to do anything there.

Also, since I forgot to mention this in the initial PR description, I also stopped the badge/title from flashing since it's unnecessary when the badge is there, and if anything would be kinda distracting with a red dot.