search

zhukov / webogram

Telegram web application, GPL v3
https://web.telegram.org
GNU General Public License v3.0
7.96k stars 2.36k forks source link

Problems in Chrome as App #309

Closed fonix232 closed 10 years ago

fonix232 commented 10 years ago

So, instead of running a web server continuously, I've decided to load Webogram as a Chrome addon/app. It was working all fine, until the past week or so. Since, any time I try to use it, this happens: image

The names are all replaced by their Angular expressions, and clicking on them does nothing. BUT, if you go through the Contacts list (which is again, displayed weird, see below), then you can get to the messaging, which shows the message bubbles, but not the message text.

It's been tested on three different Chrome installs (Mac stable, Linux beta, Windows dev channel), with the same result. But running it from Node.js, or using any hosted solution works just fine (except for my own server, which results in the same effect.)

Contact list: image

Chat screen: image

I've been thinking and some checkout problem could be the culprit, but on each tested platform I made a fresh checkout, and tried packaging it manually and running as an unpacked extension, to no avail.

zhukov commented 10 years ago

Did you follow all the instructions from https://github.com/zhukov/webogram/blob/master/README.md#running-as-chrome-packaged-app?

fonix232 commented 10 years ago

Yes I did, to no avail. No matter if I put ng-csp="" in the opening html tag or not, it results in the same.

zhukov commented 10 years ago

Do you reload app after this change? This is exactly how it looks, when ng-csp is disabled.

fonix232 commented 10 years ago

I did, between any change I removed the previously added app and added it again manually (I had the same problem before, when I did not add ng-csp to the opening tag, and then I read the manual carefully - but now it is simply not doing anything, no matter what).

By the way, a little off topic, but were you aware of some people who are selling your work on the Windows Store (both Win8.x and WP8.x markets) for 1-2$? Cause for me it seems a bit weird (in case you published the packages, I take it back, you have all the right. Anyone else, they don't.)

zhukov commented 10 years ago

The problem with packaged app is definitely on your side: 1) Current version of Chrome Web App, which is published in releases, is working fine 2) I've just done what you described and it worked without any problems.

So you should double check everything.

zhukov commented 10 years ago

Commercial distribution is legal, when the GPL is not violated. So if they publish their source - they are free to do anything. This may be weird, impolite etc, but legal. www.gnu.org/licenses/gpl-faq.html#GPLCommercially

Otherwise if the source is not published, this may end bad for them.

zhukov commented 10 years ago

@fonix232 did you figured that out? Can I close the issue?

fonix232 commented 10 years ago

Yes, sorry. My previous answer hasn't been sent for some reason,please see below.

You were right, the problem was with the Chrome installs. Ran a live Ubuntu, installed Chrome dev channel, created a package with ng-csp enabled, and it worked fine. Transferred the new package to my work computer, installed it on Chrome, and it works too. BUT if I create the package on my work computer, running my day-to-day Win8.1 install, it fails. Must be something wrong with the packaging.

The guy (Mateusz Lewko mateuszlewko@hotmail.com did not publish source code, at least not visibly on the Store page, nor can I find it online anywhere.

On 6 June 2014 21:56, Igor Zhukov notifications@github.com wrote:

Commercial distribution is legal, when the GPL is not violated. So if they publish their source - they are free to do anything. This may be weird, impolite etc, but legal. www.gnu.org/licenses/gpl-faq.html#GPLCommercially

Otherwise if the source is not published, this may end bad for them.

— Reply to this email directly or view it on GitHub https://github.com/zhukov/webogram/issues/309#issuecomment-45377838.

zhukov commented 10 years ago

BUT if I create the package on my work computer, running my day-to-day Win8.1 install, it fails.

And how do you create the package?

fonix232 commented 10 years ago

The regular way:

  1. Clone git repo
  2. Make ng-csp change
  3. Open Chrome, go to Extensions page
  4. Click "Pack extension"
  5. Select folder [git repo]\app
  6. Click "Pack Extension"

On 11 June 2014 12:24, Igor Zhukov notifications@github.com wrote:

BUT if I create the package on my work computer, running my day-to-day Win8.1 install, it fails. And how do you create the package?

— Reply to this email directly or view it on GitHub https://github.com/zhukov/webogram/issues/309#issuecomment-45724773.

zhukov commented 10 years ago

I never use that "Pack extension button". I only use "Load unpacked extension", like it's said in Readme.

fonix232 commented 10 years ago

It is pretty much the same, except the Pack Extension button creates a crx file too, and uses that.