zhukov / webogram

Telegram web application, GPL v3
https://web.telegram.org
GNU General Public License v3.0
7.96k stars 2.35k forks source link

Notification problem with emoji icon #451

Closed rubenlagus closed 7 years ago

rubenlagus commented 10 years ago

When I receive a message that contains a emoji icon (I didn't test with all of them), the notification is shown wrong:

Message received:

Message

Notification content: Notification

I'm using Chrome Browser (version 35.0.1916.114) in an Arch Linux instalation

zhukov commented 10 years ago

So what is the problem? What exactly is wrong?

zhukov commented 10 years ago

Check out #427, btw.

rubenlagus commented 10 years ago

Top notification belong to Webogram Chrome App and the bottom one to Web version. Isn't it better having both the same way(Chrome App way)?

image

zhukov commented 10 years ago

Chrome App will update very soon to 0.3.0 and it will be :stuck_out_tongue_winking_eye: in both versions. Try to send some more rare emoji, like this one: :8ball:. In 0.3.0 I have replaced emoticons with its plaintext shortcuts, because some browser can't render emoji. See #427.

I don't know any good way to learn, if browser notifications support emoji, and I have enabled them just for OS X, iOS, Android, since I'm sure about them.

ghost commented 10 years ago

Hello, I don't know if it can help... from http://www.emojione.com/

1 2

Thanks.

kostyakoz commented 10 years ago

@ben2015 now Telegram using only Apple's Emoji smiles in all apps (iPhone, Android etc.)

zhukov commented 10 years ago

@ben2015 this doesn't solve HTML5 notifications problem, as we can't use images inside notification text (this is also the reason we can't use own emoji spritesheets here).

zhukov commented 10 years ago

@rubenlagus did you install something (like plugin, font or software) to add emoji support for you browser/OS? If all the system is default we can improve regexp, which detects if userAgent supports emoji. See: https://github.com/zhukov/webogram/blob/master/app/js/services.js#L3129

rubenlagus commented 10 years ago

@zhukov These are all the extensions I have installed in my Chrome:

It is not a new installation but I think I don't have anything that makes any changes related with emoji support

zhukov commented 10 years ago

Yep, seems like there are no emoji-plugins. Can you try to reproduce this in incognito-mode just to make sure? Also, can you try the same in Firefox on the same PC? (so we learn that this is not Chrome-related feature, and an OS one).

zhukov commented 10 years ago

Any updates here?

rubenlagus commented 10 years ago

@zhukov sorry, I've been busy becoming an engineer (with my degree thesis). I will try to make the test during this week :)

rubenlagus commented 10 years ago

I tried in incognito (only the web version, chrome version doesn't allow the incognito option) and in firefox. In both of them, I'm getting the :stuck_out_tongue_winking_eye: version.... Not sure if that is what you need. If you want me to test something different, let me know.

zhukov commented 9 years ago

Is this still actual?