zhukov / webogram

Telegram web application, GPL v3
https://web.telegram.org
GNU General Public License v3.0
7.95k stars 2.35k forks source link

Update the Emoji set, add the skin tone modifier feature #760

Open wp9015362 opened 9 years ago

wp9015362 commented 9 years ago

@zhukov :

The Emoji set in Webogram is now outdated, see:

http://blog.emojipedia.org/apple-2015-emoji-changelog-ios-os-x

Could you please update the Emoji set to the latest version and could you please add the skin tone modifier feature to the Webogram Emoji drawer?

Also submitted for:

https://github.com/telegramdesktop/tdesktop/issues/639 https://github.com/DrKLO/Telegram/issues/986

Regards

magicgoose commented 6 years ago

I stopped using Telegram Web because of this bug

This is hilarious. Emoji themselves are a bug; they should not have been allowed into Unicode.

Unicode is a computing industry standard for the consistent encoding, representation, and handling of text

The fact that some guys hijacked the standard doesn't mean everybody has to support these bogus additions. The best that can be done is to treat the emoji characters as unassigned code points (that is, ignore their existence). But since this is a web application, it's up to the browser. Ideally webogram should simply assume that the browser will correctly render Unicode strings and not try fixing any issues that a browser could have, or it would be a crutch (костыль).

ingria commented 6 years ago

Emojis are ideograms. Meaning that they are as much bogus additions to Unicode, as chinese hieroglyphs or any other logogram (not bogus at all).

Carighan commented 6 years ago

@ingria : Emojione seems more sensible to me anyhow, Telegram is not just an iOS/OSX client.

stek29 commented 6 years ago

@Carighan Exactly: Telegram is not just a web client, and that's why it can't use different emoji set.

@ingria AFAIK Telegram actually pays apple licensing fees for emoji, so I'm not sure if PR could be accepted. Also, You can use https://github.com/telegramdesktop/tdesktop/blob/dev/Telegram/Resources/art/emoji_250x.webp (which is somewhat outdated too, I think), or probably pull out resources from Android app.

ingria commented 6 years ago

I have a script that creates a sprites with any emoji images and generates a JS/SCSS code. It doesn't care what images to use — Apple's, Emojione's or whatever. So I'm ready to PR any moment, as soon as I have full emoji set (and info about licensing if appropriate).

@Carighan yeah, I agree. I also like their style more than Apple's. But Telegram team aims to consistency across the clients and OSes, so they (most likely) won't accept anything except Apple emojis :man_shrugging:

StefanBrand commented 6 years ago

@ingria Thanks a lot! I get that https://botcontrol.ru/web is possible only because Telegram's API is open per se, but the official Telegram Web App could do better in regards to emojis.

flying-sheep commented 6 years ago

WhatsApp semi-recently introduced an emoji set that’s similar to Apple’s, but not a copy, and with less of that hideous gloss.

Maybe Telegram could investigate if those are available without fees.

But anyway, the webogram emoji picker is hilariously outdated, and the only thing uglier than Apple emoji is the inconsistency of seeing Apple emoji mixed with my system font’s emoji (when my conversation partner uses a newer one not available in webogram)

ror3d commented 5 years ago

Well, I've managed to implement the full emoji support in my fork. The only problem is that I couldn't find the authentic Apple emoji font/images/sprites/whatever, so I had to use Emojione (which, I suppose, is unsuitable for the official Telegram Web app).

@ingria Maybe you can do a PR of this and then find out the correct emoji set on its comments and update? This situation is starting to get a bit ridiculous.

ingria commented 5 years ago

No point to make a PR because this project is dead. The new one is being developed here, (demo).

ror3d commented 5 years ago

Oh okay, I wasn't aware of that. I see it's still under development and lacks a lot of functionality though. Could you please link to the repo where the fork I mentioned earlier was? The link doesn't seem to be working right now. Thanks so much.

LuisMayo commented 5 years ago

That "new one" is not official. If telegram has an oficial client, which is the one most people are going to use, we should try to fix it

He seems to have deleted his fork?

StefanBrand commented 5 years ago

If telegram has an oficial client, which is the one most people are going to use, we should try to fix it

Also, https://botcontrol.ru/web is blocked on my university (Vienna)... 🙄 I have to use the official webogram...

Edit: Ok, I see that the domain of @ingria's fork is https://web.tlgrm.eu now. I'll check that out. Edit2: web.tlgrm.eu works at University of Vienna. 😉

Carighan commented 5 years ago

Edit: Ok, I see that the domain of @ingria's fork is https://web.tlgrm.eu now. I'll check that out. Edit2: web.tlgrm.eu works at University of Vienna. 😉

Is that actually official? Because the official page links to the old webogram.

StefanBrand commented 5 years ago

No, it's not official. But since webogram is open source and the "official" webogram hasn't updated the emoji set, I don't see a problem in using a fork.

flying-sheep commented 5 years ago

Where’s the code for the fork? @ingria?

KevDoy commented 5 years ago

Any movement on this?

ricardofiorani commented 4 years ago

Any update on this ?