zhuowei / Boardwalk

Source code for Boardwalk, a Minecraft Java Edition launcher for Android (not actively developed)
Apache License 2.0
364 stars 55 forks source link

Nougat ZipException #304

Open AlexDicy opened 7 years ago

AlexDicy commented 7 years ago

S7 edge, Nougat 7.0 Screenshot As seen in #302

@zhuowei, I'd like to work with you on the project, is it possible?

minealex2244 commented 7 years ago

I think that no. This is closed source. Same issue here but it is related to the new storage framework used in Android N. This app is not yet upgraded to that API.

AlexDicy commented 7 years ago

Well, I asked Zhuowei ahah

minealex2244 commented 7 years ago

Can you tell me the coding languages you know? I'm planning to decompile the app and to see what I can do to test it (unfortunately it will be just for myself as it is illegal to redistribute this app but I'll see what I can do).

AlexDicy commented 7 years ago

I decompiled it an hour ago but I found some lib (.so file) which I only seen with the hex editor, it's 6KB and doesn't seem to be part of the execution

Anyway I know Java, PHP, HTML, JS, CSS, SQL and maybe something else (which I can't remember right now)

minealex2244 commented 7 years ago

That's cool. :D I think there isn't anything important in the .so files but there is something in the Storage access classes. Google made some modifications to the Storage Access Framework which is just a pain for Devs. I will try to see if there is any workaround.

AlexDicy commented 7 years ago

Alright, I'll see too, let me setup the project

minealex2244 commented 7 years ago

Here is the logcat I've taken: ---- 14 apr. 2017 18:28:31 ----

04-14 18:26:29.399 4112 4760 I System.out: Dex pack: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/dex_pack/1.9.jar

04-14 18:26:29.406 4112 4760 I System.out: Dex pack: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/dex_pack/1.9.jar

04-14 18:26:30.291 4112 4760 I System.out: Dex pack: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/dex_pack/1.9.jar

04-14 18:26:30.297 4112 4760 I System.out: Renaming: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/versions/1.9/1.9.jar to /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/tmp/1.9.jar1267705696.jar

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.util.IoUtil.pipe(IoUtil.java:33)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.util.CleanZipUtil.shardZip(CleanZipUtil.java:124)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.downloader.MinecraftLaunch.createDexPack(MinecraftLaunch.java:64)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.LaunchMinecraftTask.downloadMinecraft(LaunchMinecraftTask.java:127)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.LaunchMinecraftTask.doInBackground(LaunchMinecraftTask.java:47)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.LaunchMinecraftTask.doInBackground(LaunchMinecraftTask.java:15)

---- 14 apr. 2017 18:28:31 ----

AlexDicy commented 7 years ago

ok thanks for the logcat let me see what's in the Java file

AlexDicy commented 7 years ago

And that's just one error, I don't really know what's happening, maybe you used another decompiler, do you mind sharing the src? screen

minealex2244 commented 7 years ago

Which tool did you used to decompile the apk file? A JadX based one? I ask this because I like the way the app was decompiled.

AlexDicy commented 7 years ago

@minealex2244 I used dex2jar for the jar and jd-gui for the .java files But what are you talking about, the colors?

minealex2244 commented 7 years ago

I know a lot of tools​ to decompile apks but I see that your apk was decompiled very good. I don't mean the IDE but it is cool too. Now that I have some free time I'll try to decompile it to see what's inside.

juliuscaesar1597 commented 7 years ago

Same as #299

EmotionalLove commented 6 years ago

How has the app decompiled for you guys? I've written in java for a long time and I've had the idea to decompile it and see if I can fix it (it should be simple), but I'm not sure if it'll even decompile correctly.

zhuowei commented 6 years ago

@2F4Uof2b2t Decompilers won't give recompilable code. Disassemblers may work, but please don't.

AlexDicy commented 6 years ago

@zhuowei you should provide a way to fix these issues. The app is unusable right now.

zhuowei commented 6 years ago

I know, and I have plans for a rewrite.

AlexDicy commented 6 years ago

@zhuowei ok, thank you.

lerepex commented 6 years ago

@khanhduytran0 Could you please release instructions in how to do this? Or even better Upload the APK?

gingerbryn1 commented 6 years ago

@khanhduytran0 could you elaborate, any help would be great as I've been at this for over a year ;-;

zhuowei commented 6 years ago

@khanhduytran0 This doesn't look like Boardwalk 1.9 - it's using the regular Android ART runtime, not Boardwalk 1.9's (failed) attempt to use a different runtime. Also, pretty sure distributing Minecraft JARs pre-dexed in the APK breaks the Minecraft license.

Why gl4es instead of glShim? Does it work better? I might switch to it for Boardwalk 2.

Edit: ... ok gl4es isn't used anywhere. Why is it included then?

I haven't tried this: how well does it run on newer phones?

Edit: why does this rip out Boardwalk's Minecraft login code? Minecraft still uses the same authentication system.

Edit: I see a button for "Mods manager (Forge)" in your app, but I don't think it works? Your app doesn't convert files from Java to Android dex at all, so no mods would/could ever load. Adding mod support in Boardwalk would require a rewrite (which is why 2.0 is taking so long); I'll be interested to see how you would get it working.

I should probably yell at you for using Boardwalk code without permission, (and I will need to ask you to take this down eventually), but for now, good work.

minealex2244 commented 6 years ago

It is working pretty well on newer devices. I have a Samsung Galaxy S9 and I'm getting 30+ fps. Sometimes I'm getting 60 fps with just view bobbing enabled and with chunks rendering set to 5. Water is causing lag because of the animation. Optifine would fix everything. Good work @khanhduytran0 👍🏻

gingerbryn1 commented 5 years ago

@khanhduytran0 have you already taken down the repository ;-;

minealex2244 commented 5 years ago

@khanhduytran0 I have used 1.7.10. I'm not sure about Optifine API. I'll search for it. Edit: It looks like Optifine is just a patched Minecraft jar file.

Letfordlay commented 5 years ago

@khanhduytran0 where is the download for your app? I would love to try it on my galaxy s9

gingerbryn1 commented 5 years ago

@khanhduytran0 this is impressive

XxSp0oky777xX commented 5 years ago

It works.... it runs minecraft just as well as my 4gb computer XD....(using this on galaxy s9)

Letfordlay commented 5 years ago

@khanhduytran0 It runs very well on my galaxy s9, very impressive!

sgdc3 commented 5 years ago

@khanhduytran0 could you publish the sources?

EmotionalLove commented 5 years ago

@zhuowei I feel like if you made Boardwalk an open source project that it would be more successful if the community could contribute to the project with pull requests. For example @khanhduytran0 got it running on Android 7 and up and it runs very smooth (60fps on my GS9)

You should seriously considering publishing the sources under an open source license like the GPL3 and accepting pr's.

zhuowei commented 5 years ago

@EmotionalLove My plan is to replace Boardwalk's Java layer to support modloaders: I've started on that during March and laid some of the groundwork and will pick it up again during this month.

Once that's released, I'll see if I can make Boardwalk 1 open source.

EmotionalLove commented 5 years ago

That would be cool! Thanks for the consideration! :innocent:

On Tue, Oct 30, 2018, 6:02 PM zhuowei notifications@github.com wrote:

@EmotionalLove https://github.com/EmotionalLove My plan is to replace Boardwalk's Java layer to support modloaders: I've started on that during March and laid some of the groundwork and will pick it up again during this month.

Once that's released, I'll see if I can make Boardwalk 1 open source.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zhuowei/Boardwalk/issues/304#issuecomment-434524516, or mute the thread https://github.com/notifications/unsubscribe-auth/AS9YmYjbMucygglW9T8z65AlrdPmEsFrks5uqPa9gaJpZM4M8zfM .

juliancz-a commented 5 years ago

OMG THIS IS AMAZING, I have been able to play in this application on my Xiaomi Mi A2 Lite that has a Snapdragon 625, a medium range that ran to 20 - 30 in a normal world OMFG !, I realized that water gives a lot of lag, true ? In a flat world the fps up to 45, thank you very much, really. Some questions: Can I install optifine to improve performance? Could I upload this to YouTube in order to make it known to more people? If the answer is no, there's no problem, I'll understand the multiplayer is available? I wish it were out hopefully continue with this project working in community Greetings from Argentina, guys. I apologize for my bad English (and I'm sorry for being so misinformed on the subject, is that I just saw the link I downloaded xD).

juliancz-a commented 5 years ago

Hello, Thank you very much for answering, could you solve the chunks? or is it my mobile's fault? I hope I can try optifine, and thank you very much for letting this go to YouTube, I will leave all the credits. What a joy that servers can play in the 1.7! Hopefully if at any time the project is updated I hope to be aware of them.

juliancz-a commented 5 years ago

Sorry, I'm back I have a problem trying on a server version 1.7 / 1.8 http://i.imgur.com/3z2T6l6.jpg what a pity that you can not solve the chunks :( Another thing, when I write a letter, I write several "AAAAAA" before the letter that I played example: "AAAAAAAAAt" I can thank you very much for everything.

juliancz-a commented 5 years ago

When it came out the "AAAA" was with the default keyboard of Google or something like that. Then I tried with SwiftKey keyboard and it seems to work fine, I'm not sure why in 1.8 the keyboard does not work with chat, I want to write to login and it does not work, by the way, the option to enter with a premium account is not available, I hope you implement it :) Can you give me a solution to write in version 1.8? Is that my preferred server is only for that version thanks again.

juliancz-a commented 5 years ago

No hurry, I just want to let you know the errors that there are, in 1.7.10 the keyboard and chat are perfect, like the multiplayer, the only bad thing is the load of chunks that freezes the game otherwise very good work, congratulations.

juliancz-a commented 5 years ago

Okay, I discovered this but surely you knew XD, in version 1.9 apparently the loading and saving of chunks does not cause low fps and it is quite playable, obviously the 1.9 is much worse than the 1.7 but does not give those unbearable drops.

DanyGames2014 commented 5 years ago

@khanhduytran0 do you still develop it or not ?

DanyGames2014 commented 5 years ago

@khanhduytran0 is there any repository or download site for your launcher ? also is there a way to allocate more ram ? also what format i need to load mods

DanyGames2014 commented 5 years ago

@khanhduytran0 I have that version installed but I just wanted to know if there are newer versions with maybe 1.12.2 version working

Beaness commented 5 years ago

@khanhduytran0 Are you planning to make your own repo? It actually dont need any files on it but it could be usefull for issue tracker.

zhuowei commented 5 years ago

I'm slowing starting to upload Boardwalk's source to GitHub. Please be patient, as I haven't built Boardwalk 1.x in a long time and I need to make sure I have the correct source.

I've uploaded the source of the modified LWJGL and glShim libraries used in Boardwalk to https://github.com/BoardwalkApp.

I'll need to look through the source code of Boardwalk itself before uploading it; that should be up later this week.

Edit: Boardwalk 1.2's source has been pushed as well.

Edit: Boardwalk 2.0's wip source also pushed.

leomelki commented 5 years ago

Can someone send me the working apk you've got please?

ghost commented 5 years ago

@khanhduytran0 could you link to me your version please?

khanhduytran0 commented 5 years ago

Here https://youtu.be/kenBd-8u9E8 I takes a lot of times for v2 design and some updates. EDIT: it may don't work on your device (android 7 or above)

szarik001 commented 5 years ago

@khanhduytran0 is there any way to allocate more RAM or is it limited to 512mb?

Letfordlay commented 5 years ago

@khanhduytran0 I tried it on my Galaxy s10e running android 9 and when I try to launch any version of the game I get an error Screenshot_20190825-204257_PojavLauncher (Java Edition) (1) Screenshot_20190825-204116_PojavLauncher (Java Edition) Screenshot_20190825-203834_PojavLauncher (Java Edition)

khanhduytran0 commented 5 years ago

Now i don't have full time to fix, maybe few days later (by replacing to a new dx)

KorewaLidesu commented 5 years ago

@khanhduytran0 did you change the video privacy to private?