zhuowei / MCPELauncher

Source code for BlockLauncher, a launcher that patches Minecraft for Android
Apache License 2.0
682 stars 189 forks source link

New bugs and glitches #1017

Open Virus5600 opened 8 years ago

Virus5600 commented 8 years ago

Ok, to start of, I wanna congratulate you and thank you for this app so "Thanks and congratulations @zhuowei!"

Back to the point, the new update this week that supports the 0.14.2+ versions makes it harder for me to check my mod if there was any bugs and/or glitches cause some functions aren't working properly. One good example is the ModPE.showTipMessage(); that I use for the countdowns and timers. It also crashes when some block of codes were executed.

This is the code I use and function well before the update that crashes the app every time it's executed: if (Player.getCarriedItemCount() > 1) { Entity.setCarriedItem(getPlayerEnt(), 1004, Player.getCarriedItemCount()-1, 0); } else { Player.clearInventorySlot(Player.getSelectedSlotId()); };

This is the new code I'm using after the update that didn't crash when executed: if (Player.getCarriedItemCount() > 1) { Entity.setCarriedItem(getPlayerEnt(), 1004, Player.getCarriedItemCount()-1, 0); } else { Player.clearInventorySlot(Player.getSelectedSlotId()); };

DiegoGTRatty commented 8 years ago

Unless I have eye issues they both look the same...

zhuowei commented 8 years ago

@SatchTFF Your code isn't crashing for me. (also yeah, you're right, @DiegoGTRatty, the two code samples are identical)

function useItem(x, y, z, itemId, blockId, side) {
    if (itemId == 4013) {
        if (Player.getCarriedItemCount() > 1) {
            Entity.setCarriedItem(getPlayerEnt(), 4013, Player.getCarriedItemCount()-1, 0);
        } else {
            Player.clearInventorySlot(Player.getSelectedSlotId());
        };
    }
}

works fine.

What's wrong with showTipMessage? The new implementation doesn't support colour codes: I know this is an issue and I'll fix it later.

Virus5600 commented 8 years ago

I know its completely identical and thats the reason Im confused too. I replace it woth the new that looks completely the same but the new one is fine.

The ModPE.showTipMessage doesnt show up when its called. Is it becaise of the color codes? If yes then Ill retry if its really the colors since Im using § instead of the CHAT... code

Virus5600 commented 8 years ago

screenshot_2016-05-26-21-06-44 screenshot_2016-05-26-21-06-20

Looky here @zhuowei. The showTipMessage isn't working while the clientMessage still works.. The showTipMessage has no colors though.

Virus5600 commented 8 years ago

A new bug has appeared! @zhouwei, what did you use for the showTipMessage();? Is it on the system or in the app?

The showTipMessage is overlaying the app makong it unmovable while the showTipMessage is running. In addition, the showTipMessage is executed much longer making a countdown feature for showTipMessage a delayed counter.

DiegoGTRatty commented 8 years ago

I think the showTipMessage is related to the Android system itself, since it uses a function Android uses for notifications in general (like displaying "some app was successfully downloaded")