search

zhuowei / MCPELauncher

Source code for BlockLauncher, a launcher that patches Minecraft for Android
Apache License 2.0
683 stars 189 forks source link

Blocklauncher Crashing with my mod that worked on 0.12.3 #346

Open QuintonMostert opened 8 years ago

QuintonMostert commented 8 years ago

My creeper buddies mod worked on 0.12.3 now it crashes when i spawn a creeper buddy i think it has something to do with the set text in the gui functions

Heres the script : http://qbot.tk/CreepaBuddys.js

zhuowei commented 8 years ago

I can't download the script (gives a "Not found") error - you might want to check if you got the address right

duggum commented 8 years ago

If you are referring to the script at http://qbot.tk/CreepaBuddys4.js, it was riddled with errors. I went through it and fixed what my code linter found and saved it as creeper-buddy.js. I loaded it and it seems to work fine.

All files are attached including your original, my corrections, and the diff file that shows you what I fixed.

FYI, I had to add the .txt extension in order to attach the files.

CreepaBuddys4.js.txt

creeper-buddy.js.txt

CreepaBuddys4.diff.txt

QuintonMostert commented 8 years ago

dude it still crashes the game when a creeper buddy is spawned and it was working fine in 0.12.3 zhuowei please fix this :(

duggum commented 8 years ago

Dude, my version of your script. The textures aren't right because of a custom texture pack, but they work fine with default texture (i.e. the Fire Creeper is orange, see the last two pics).

BlockLauncher Pro 1.11 and BlockLauncher 1.11.1-b3 MCPE 0.13.0

EDIT: Deleted images since they are not relevant to the problem and they made the thread less readable.

QuintonMostert commented 8 years ago

dude the creeper buddies not the elemental creepers the pets !! you need to spawn it and name it .... Image of Yaktocat

they dont work since @zhuowei updated plz fix it zhuowei also fix the rideMob function it crashes the game

duggum commented 8 years ago

Gotcha...I didn't know about the spawning trick, I just tested the chat command spawning. I do get a crash when triggering the spawn from the egg drops.

You might want to include detailed instructions so @zhuowei knows what to do to replicate your problem.

QuintonMostert commented 8 years ago

Okay @zhuowei this script does not work anymore please can you fix it to replecate the problem Install this script : http://qbot.tk/CreepaBuddys4.js Go into creative and in the seeds section at the bottom get the Creepa buddie spawner the chicken egg And spawn it the game will then crash ... This is the problem :(

zhuowei commented 8 years ago

I think this is the same issue as Pokedroid (anything that sets transparency to true in setTextureOffset crashes), since the mutant creeper uses transparent textures. Try 1.11.1 release, which should fix this.

QuintonMostert commented 8 years ago

thanks @zhuowei fixed it!