zhuoyang125 / pe

0 stars 0 forks source link

Greater elaboration on invalid inputs when adding contacts #10

Open zhuoyang125 opened 2 years ago

zhuoyang125 commented 2 years ago

Screenshot 2021-11-12 171828.png

In the app, two users cannot share any similar fields, and any attempt to do this will be seen as invalid inputs. This could be documented in greater detail, such as in the add command. Users who are editing fields of contacts, for example, may have to discover on their own what is valid or invalid.

nus-se-script commented 2 years ago

Team's Response

When the user uses the application, they will know about the error that is brought about by duplicated fields. This is an input validation that does not need to be stated in the user guide. Nevertheless, it would bring good to alert the user beforehand in the user guide, and therefore the bug is accepted at the severity of "very low".

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I feel that the severity should be changed to Low instead. For most apps, only a few fields will lead to duplication errors, and it is easy for the user to figure out what's invalid on their own. In this case, however, all the fields in person may lead to duplication error (i.e. same email, same github, same phone number) and I experienced some inconvenience having to fix many duplicate errors.

I feel it would help the user a lot if it was mentioned in the UG that no field should be the same, to prevent them from making a lot of errors in the first place.