Parameter LINKFLAGS should be LDFLAGS

zhupan / serf

Automatically exported from code.google.com/p/serf

Apache License 2.0

0 stars 0 forks source link

Parameter LINKFLAGS should be LDFLAGS #117

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

The common name is LDFLAGS. We should follow this convention.

Original issue reported on code.google.com by 1983-01...@gmx.net on 5 Aug 2013 at 8:04

GoogleCodeExporter commented 9 years ago

Original comment by chemodax@gmail.com on 9 Aug 2013 at 4:53

Added labels: scons

GoogleCodeExporter commented 9 years ago

When adding these flags I have chosen to use the scons names, it would be 
unintuitive if we mixed multiple naming conventions.

So AFAIC we won't fix this.

Lieven

Original comment by lieven.govaerts@gmail.com on 17 Sep 2013 at 11:28

Changed state: WontFix

GoogleCodeExporter commented 9 years ago

Agreed but docs should mention this IMHO because most folks are not familiar 
with scons.

Original comment by 1983-01...@gmx.net on 17 Sep 2013 at 1:21

GoogleCodeExporter commented 9 years ago

Ok, to which docs are you referring?
scons --help has a short description of all flags including LINKFLAGS (without 
any ref to LDFLAGS though)
README doesn't mention any of the special build flags, but refers to scons 
--help.

Original comment by lieven.govaerts@gmail.com on 18 Sep 2013 at 6:25

GoogleCodeExporter commented 9 years ago

Well then, its fine. Thanks for the insight.

Original comment by 1983-01...@gmx.net on 18 Sep 2013 at 10:42