search

zhutik / adyen-api-go

[Deprecated] Adyen API Library for GO
https://godoc.org/github.com/zhutik/adyen-api-go
MIT License
22 stars 12 forks source link

add NewStringBool #66

Closed sywesk closed 6 years ago

sywesk commented 6 years ago

Add the NewStringBool function 👍

Sorry for the previous PR, i messed up somehow. :/

sywesk commented 6 years ago

@zhutik

boolean.go:12:28: exported func NewStringBool returns unexported type *adyen.stringBool, which can be annoying to use Found 2 lint suggestions; failing.

zhutik commented 6 years ago

Seems like code quality check tool suggests to export stringBool type to avoid confusion in a client apps. So let's also do that.

sywesk commented 6 years ago

The build is failing on what looks like an empty environment variable $COVERALLS_TOKEN

$ goveralls -service=travis-ci -coverprofile=gover.coverprofile -repotoken $COVERALLS_TOKEN
flag needs an argument: -repotoken
zhutik commented 6 years ago

@sywesk yeah, this variable is not exposed for repo non-masters. I added the new key that would be open. Build restarted, should fine soon. Sorry for inconveniences.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.6%) to 65.659% when pulling d4405db8e79ab39200dfbb532f075891390764b3 on sywesk:master into fa10debd45812926c6f9687ebfed6f3e031ac25f on zhutik:master.

sywesk commented 6 years ago

Nah don't worry 😄 thank you for helping me with this build process