zhuuyicheng / pe

0 stars 0 forks source link

Planned enhacements are new features instead of tweaks to existing features #13

Open zhuuyicheng opened 6 months ago

zhuuyicheng commented 6 months ago

image.png

image.png

As stated in the textbook, the planned enhancements should not be completely new features. Adding new commands like what point 2 and 3 are suggesting is adding new features and are not considered enhancements.

soc-se-bot commented 6 months ago

Team's Response

We believe that the feature to view schedule was highlighted previously to not match the target user's preference for CLI, and the drop-down box hinders the users, as a way to tweak our feature, we have opted to use a command for it instead. Therefore, it is not an entirely new feature, but an alternative for our existing feature.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: After some deliberation, point 3 could be argued to be an enhancement because it complements the existing GUI element with a command-line interaction, and the core functionality remains the same. However, point 2 is still a new feature because this suggests a completely different way to view schedules, which is by "searching" for schedules of the specific week/date which changes the current display. The current system only allows users to view schedules without allowing for date navigation, so this point adds a significant functionality change. This change can be akin to "searching by name" vs "searching by date" which are fundamentally different features.


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** If the planned feature tweak is flawed/inadequate, it should be marked as a type.FeatureFlaw according to the textbook. ![image.png](https://raw.githubusercontent.com/zhuuyicheng/pe/main/files/31d82662-0751-41ee-8be3-843ebcc93d70.png)