search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Undocking with a broken weapons group segfaults #121

Closed ryllae closed 4 years ago

ryllae commented 4 years ago

Undock an ANI, and group your 7 energy turrets Dock up. Remove a weapon. You get a message saying you will break your weapon group. Ok. Remove another weapon (get another error message, but why? We should have broken the weapon group?) Keep doing this until you've removed all 7.

Now equip 7 new (different) turrets. Undock, crash.

ryllae commented 4 years ago

Part of https://github.com/zhyrohaad/AlasiyaEvE/issues/82

zhyrohaad commented 4 years ago

touch

ryllae commented 4 years ago

Confirmed on dev eb777b, exactly as above. You can even do this with 2 blaster cannons on any ship.

ryllae commented 4 years ago

Upon logging back in, I get a There was an error loading a weapon group master. ServerError 06123

zhyrohaad commented 4 years ago

ohhhh that's helpful. i havent actually looked at this yet, but that error msg/# tell me where the problem is. i need to finish that error system for everything else. :)

zhyrohaad commented 4 years ago

Updated. The weapon grouping code was missing a call to delete the group data when client requested a module removed from the group. This has been fixed and main updated.

ryllae commented 4 years ago

I recreated an 8-blaster group, docked up, removed one blaster (got the error message saying I was breaking a group), undocked, crashed. Only other thing that seemed out of order was the the weapon I removed had no charges (which is obviously a different bug).

zhyrohaad commented 4 years ago

with current updates, i havent been able to segfault from grouping weapons not gonna say fixed, as there are still problems with grouping, but i dont see a way to fix using client code. see what you get when you get a min, then continue on the other weapon group errors. #82

ryllae commented 4 years ago

No longer crashes, but there's a laundry list of group ammo problem.

zhyrohaad commented 4 years ago

yeah, this is more complicated than i had originally thought.
theres still a bit of work to do on it.