zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

After jumping, ships should be cloaked and invulerable for some amount of time #127

Closed ryllae closed 3 years ago

ryllae commented 4 years ago

I don't recall the exact mechanic, but I know it's totally unimplemented so far.

zhyrohaad commented 4 years ago

no, that's been working for years. the cloak is 30s and invul is 15s for jumping. cloak is removed on any movement (except stop) or offensive module activation. invul from undock is 20s. removed on any movement (except stop) or offensive module activation.

edit wow, cloak isnt working, but invul is. theres' no telling what all is currently broken, but i'll have to test my updates on main server, because most of this is working on dev server.

zhyrohaad commented 4 years ago

touch

ryllae commented 4 years ago

Confirmed on dev eb777b: you aren't cloaked after a jump. Invul works after undock.

zhyrohaad commented 4 years ago

after looking over this, the call to Cloak() was removed and i cant find when or why. this has been corrected.

ryllae commented 4 years ago

Working.

ryllae commented 4 years ago

I was testing #125 and encountered a mysterious regressions on cloaking:

Have two ship undock and head to the local gate. Jump them both at the same time, they came out cloaked as expected. I immediately had both return to the gate and jumped again. When back in the starting system, one ship was cloaked, but appeared on the Overview of the other (oops?). The other ship was not cloaked (oops!). Continuing to jump back and forth didn't show a particular pattern that I could discern, but usually jumping back was a most broken?

zhyrohaad commented 4 years ago

fixed and updated.

ryllae commented 4 years ago

135 makes this issue difficult to test, but in the one time I jumped there and back successfully, I wasn't cloaked on return.

zhyrohaad commented 4 years ago

this ties into bug #135 with timers and checks. working on this with others

zhyrohaad commented 4 years ago

fixed and main updated

ryllae commented 3 years ago

Better.