search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Fitting window breaks with a Covert Ops Cloak #128

Open ryllae opened 4 years ago

ryllae commented 4 years ago

While docked, drag a Covert Ops Cloaking Device to a high slot of a Buzzard. The item "disappears". If you undock, the item in the high slot.

ryllae commented 4 years ago

This also applies to a [Prototype|Improved] Cloak when attached to a rifter.

zhyrohaad commented 4 years ago

this is an fx data error it will require a processing rewrite to fix (incompatible data types) eta unknown

zhyrohaad commented 4 years ago

this particular error affects 138 modules i am working on a fix, but so far having no luck

zhyrohaad commented 4 years ago

managed to find a 'dirty' fix for this. main updated

Edit To offer some explanation: The problem is fairly simple in this case; the client does it's cap stability check for fitted modules using their default effect. When that effect doesn't have proper values (should be none instead of 0), the data gets funky and hits a divide by zero error. This lack of proper values is due to how server is sending fx data to client. Our current DB handlers doesn't send PyNone properly, and sometimes sends as 0. Client does value test as if x is None but our sending of 0 makes that conditional false, so flow continues which leads to undefined division. My Jacky fix was to remove the default effects that don't have the values assigned (which aren't used anyway) This may be addressed differently later.

zhyrohaad commented 4 years ago

Update again. Turns out default effects ARE used....they tell the server what effect is being activated. Because cloaks (and couple others)no longer have default fx, they won't activate. Will work on this as I get more time.

THUNDERGROOVE commented 4 years ago

I've released a temporary client fix for this for AlasiyaLauncher users to correct for the None checks. This fixes the fitting window and disappearing modules for now however cloaks are still non-functional.

zhyrohaad commented 3 years ago

thanks to groove, this is fixed. i have pushed a patch to main server that corrects this problem. @ryllae pls test again and report findings

ryllae commented 3 years ago

I still see the initial problem: take an fresh Buzzard, drag a Covert Ops Cloak II to it. the fitting window doesn't show that it's there, but can confirm if you undock. WHen docking, the cloak is there, but interacting with it still breaks the window.

zhyrohaad commented 3 years ago

will do more testing to see what ive missed.