search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Removing modules in space while running keeps their benefits #77

Closed ryllae closed 4 years ago

ryllae commented 4 years ago

Undock an Orca. Equip multiple Invulnerability Fields, activate them. Open the fitting window, and unfit the modules. You briefly see an error saying you can't offline a module while it's running. You retain the bonuses of the running module. Requip them, repeat until you have 99.99% resistances :) Capture

zhyrohaad commented 4 years ago

wow that's interesting to say the least. on the plus side, dock or relog will reset ship to default then recalculate mods.

i have found multiple errors in module code while tracking recent bugs. im updating main with fixes as i get them done, but this may lead to other bugs. this is a case-in-point....woudlnt have known this before #19 was fixed. lol

most of the bugs are things i didnt (or wont) think of.

update this was an easy fix. modules call Offline() before removal and the code for checking module states when calling a state change was already in place (and use for function testing logs). i added call to stop cycle before offline in this case. done.

zhyrohaad commented 4 years ago

fixed and main updated.

ryllae commented 4 years ago

Still broken. I get a "your invulerabilty field must finish its cycle before going offline" error, and I still get the bonus when I click the "unfit" radial button. The CPU consumption is also remains present from the "phantom module".

On the plus side, I also broke 1.2 trillion EHP on my Orca without too much effort. Annotation 2019-12-03 205639

zhyrohaad commented 4 years ago

yeah.....i forgot to restart after compiling update. updated now.

ryllae commented 4 years ago

fixed!