search

ziadoz / awesome-php

A curated list of amazingly awesome PHP libraries, resources and shiny things.
Do What The F*ck You Want To Public License
30.83k stars 5.06k forks source link

Abandoned project? #981

Closed roukmoute closed 4 years ago

roukmoute commented 5 years ago

You have many pull requests and the latest updated is several months old.

andreasschroth commented 5 years ago

Yes, it seems abandoned, unfortunately.

donis commented 5 years ago

No it's not. Most of those pull requests don't conform to contributing guidelines.

kubawerlos commented 5 years ago

Then, it would be good to close them - 162 pending PRs does look like an abandoned project.

rybakit commented 5 years ago

Most of those pull requests don't conform to contributing guidelines.

@donis Do you mean ones marked with the "needs explanation" tag? If so, then there are "only" 35 such prs (out of 162 total opened), which is way less than "most of them".

donis commented 5 years ago

No, I mean PRs that have self-promotion posts, PRs that add libraries which are not "awesome" or even popular. Sure, maintainers are not adding everything they can here, but I don't see any reason to announce this abandoned just because of a high number of PRs.

andreasschroth commented 5 years ago

If the PRs are just self-promotion and do not conform to the contribution guidelines, they should be closed. If the PRs need further explanation / consideration / whatever they can remain open, but 162 open PRs? The oldest ones from end of 2015?

This project looks (not saying it is) abandonned or at least not taken care well of. A clean-up would do well here. That's just a personal pov and sure, it's open-source and I think we're all thankful if someone invests his spare time into this, but I think the question raised from @roukmoute is totally legit.

ericpoe commented 5 years ago

Once #976 is merged, it should at least help PRs that are non-compliant due to broken URLs in master. Existing PRs would need to merge master in order to get the updated non-broken URLs.

donis commented 5 years ago

@andreasschroth nothing "should" be done here and the maintainers maintain it as they see fit. Don't forget this is a voluntary work and no one is obliged to meet your expectations. Feel free to fork it!

@ericpoe this PR (as is #962 ) doesn't follow the rule "Please make an individual commit for each suggestion in a separate pull request."

Generally I agree, this project is very slowly updated, but there are PRs merged here and there. There is probably a good reason why maintainers are away, but how can we help to improve this situation?

andreasschroth commented 5 years ago

@donis I was actually thinking about forking it and yes, will probably do, but I haven't finally decided on it yet. Because if I'm gonna fork it, I want to make sure it's properly maintained over a long period of time and not just a one-time improvement. But that doesn't change anything on the impression the community here has that this project looks abandoned and I still doubt that's because of the PR quality.

ericpoe commented 5 years ago

@donis I guess I don't see each line as a separate suggestion but as a bug fix. "A separate suggestion" would be a separate "wow, this is awesome" suggestion. This is just to fix broken stuff.

donis commented 5 years ago

I definitely agree. I'm just trying to find reasons why some PRs are merged and some are not.

ziadoz commented 5 years ago

This project isn't abandoned. That being said, it's obvious to anyone that I've neglected it. That's primarily down to me being strict about my work/life balance, taking better care of my mental health, and things going on in my personal life which are far more important.

There are often submissions that don't meet the guidelines or are duplicates, which has affected my enthusiasm. Identifying these is most cases is manual and tedious - plus the bot that made our lives a little easier appears to be dead, which sucks.

I'm sorry if it feels like things are quiet here, that's not my intention. Thankfully @josegonzalez does a fantastic job, so things do move along, but I'll have a think about how to bring onboard another collaborator.

@ericpoe Thanks for your clean up PR, I've merged it. There are still some outstanding errors, but I'll take a peek at them when I get a moment.

ericpoe commented 5 years ago

@ziadoz #988 should take care of those outstanding errors.

ziadoz commented 5 years ago

@ericpoe Fantastic. Thanks for sorting that, I've merged your PR.

m1guelpf commented 5 years ago

If you need more eyes on this, I'd be happy to help as a mantainer :)

josegonzalez commented 5 years ago

I've stopped really looking at this repo. I think a lot of the projects come in from people trying to promote their own stuff, and people get really upset if their issues don't get merged.

I wonder if someone could write a quick script to validate a repository against the rules of contributing...

k4s0 commented 5 years ago

If needed, I'd be happy to help as a mantainer too :)

andreasschroth commented 5 years ago

Happy to help as well if wished / needed. I visit / work with Github daily and would be glad to merge PRs / reject them according to the project guidelines.

Please feel free to message me (e-mail is inside my profile).

ErikThiart commented 5 years ago

The integration bot seems broken.

ziadoz commented 5 years ago

@ErikThiart The bot was indeed broken. I removed its access from this repo a few months ago though, so it won't affect new pull requests.