search

ziatdinovmax / gpax

Gaussian Processes for Experimental Sciences
http://gpax.rtfd.io
MIT License
205 stars 27 forks source link

Remove jaxopt from pyproject requirements? #106

Closed matthewcarbone closed 6 months ago

matthewcarbone commented 6 months ago

https://github.com/ziatdinovmax/gpax/blob/2c69987b9e96b69b5dcf92c4d9b4fc118be19769/pyproject.toml#L30

It's not clear where this is used. There is a reference to it in gpax/acquisition/optimize.py. Is this one of those times where a dependency has an import that isn't strictly required?

ziatdinovmax commented 6 months ago

We need it for continuous acquisition functions. Currently this functionality is very limited (the assumption is that in experiment you always deal with discretized parameter space) and is outside of the primary package applications - hence, it is an optional dependency.