search

zibasec / django-saml2-pro-auth

SAML2 authentication backend for Django wrapping OneLogin's python-saml package https://github.com/onelogin/python3-saml
MIT License
30 stars 28 forks source link

KeyError at /sso/saml/ #23

Closed santiagovassallo closed 6 years ago

santiagovassallo commented 6 years ago

Hello! I'm having an issue with the user mapping process, because the configuration of the saml where I work doesn't return the key if the user doesn't have the atribute. So when it reaches to the point of mapping, it's possible that saml_data doesn't have one or more keys that have been specified in the SAML_USERS_MAP.

Is it possible to consider this and maybe do this process less strict by controlling if the user_key is in saml_data before asigning it?

Thank you a lot!

juliedavila commented 6 years ago

Moving discussion to your PR

juliedavila commented 6 years ago

Addressed in #24, available on PyPi under version 0.0.7 and in the source under a git tag with the same version. Thank you for your contribution @santiagovassallo!

santiagovassallo commented 6 years ago

You are welcome! And thank you for this awesome project!