search

zicht / htmldev-bundle

Library - Easy living styleguides with Symfony and Twig
MIT License
4 stars 1 forks source link

Faker is used but not required #20

Closed boudewijn-zicht closed 7 years ago

boudewijn-zicht commented 7 years ago

There is a use Faker\Factory in HtmldevExtension.php. This causes php to look for this file... in many different locations.

problem: This causes file IO overhead, and hence bad performance.

solution:

access("/home/p_diab/diabetesfonds.nl/vendor/composer/../../src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                                    
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/buckaroo-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                 
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/util/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                            
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/util/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                          
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/itertools/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                       
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/itertools/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                     
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/framework-extra-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                          
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/framework-extra-bundle/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                        
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/admin-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                    
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/admin-bundle/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                  
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/url-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                      
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/url-bundle/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                    
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/symfony-util/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                    
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/symfony-util/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                  
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/menu-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                     
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/menu-bundle/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                   
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/page-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                     
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/page-bundle/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                   
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/moxiemanager-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                             
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/filemanager-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                              
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/filemanager-bundle/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                            
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/drupal/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                          
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/drupal/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                        
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/htmldev-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                  
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/solr-bundle/src/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                     
access("/home/p_diab/diabetesfonds.nl/vendor/composer/../zicht/solr-bundle/tests/Faker/Factory.php", F_OK) = -1 ENOENT (No such file or directory)                                                   
stat("/home/p_diab/diabetesfonds.nl/app/Resources/views/ZichtDiabSiteBundle::macros.html.twig", 0x750c7f598b20) = -1 ENOENT (No such file or directory)
TowardsDeath commented 7 years ago

Should be fixed in release 2.3.2.