search

zicht / htmldev-bundle

Library - Easy living styleguides with Symfony and Twig
MIT License
4 stars 1 forks source link

Add menu uri voter #44

Closed 7ochem closed 4 years ago

7ochem commented 4 years ago

For getting the current menu item, the Htmldev Bundle Styleguide relies on a service that is being added bij the Zicht Menu Bundle. Since the Zicht Menu Bundle is not a requirement, the Htmldev Bundle on a vanilla Symfony install does not have this service and cannot resolve the current menu item.

Since the Zicht Menu Bundle depends on Sonata, it would not be realistic to require the Zicht Menu Bundle within the Htmldev Bundle just to have this one single service available.

Therefor I added this service to the Htmldev Bundle.

boudewijn-zicht commented 4 years ago

@7ochem Does this mean that the service introduced here is also present in the MenuBundle? If so, that should be removed and this bundle should require at least the version of the MenuBundle where is no longer exists

7ochem commented 4 years ago

Does this mean that the service introduced here is also present in the MenuBundle?

Yes. Both bundles have their own implementation

If so, that should be removed

It cannot be removed in the MenuBundle because the MenuBundle does not require the Htmldev bundle. Or do we want to force porjects into having the Htmldev bundle pulled in if they need the MenuBundle?

and this bundle should require at least the version of the MenuBundle where is no longer exists

This bundle requires only the knplabs/knp-menu-bundle. It does not need the zicht/menu-bundle for anything.

I think the solution I went for here (both bundles their own implementation) is the most clean solution for now.

boudewijn-zicht commented 4 years ago

:+1: