search

zicht / messages-bundle

Library - ZichtMessagesBundle - Edit your translations in the database
MIT License
1 stars 0 forks source link

[fix] Fix error when using multiple filters in messages admin #45

Closed YuenZicht closed 1 year ago

YuenZicht commented 1 year ago

Example site with bug gritco.nl

Version 7.1.0

Steps to reproduce 1) go to "Other / Translations" 2) Use all 3 filter types: "Message domain", "Message", "State"

Error message

An exception has been thrown during the rendering of a template ("[Semantical Error] line 0, col 111 near 't WHERE o.domain': Error: 't' is already defined.").

Query

SELECT o FROM Zicht\Bundle\MessagesBundle\Entity\Message o 
LEFT JOIN o.translations t 
LEFT JOIN o.translations t 
WHERE o.domain LIKE :domain_0 
AND (o.message LIKE :tr OR t.translation LIKE :tr) 
AND t.state = :status 
ORDER BY o.id ASC

message admin filters image

boudewijn-zicht commented 1 year ago

Jeetje, bugfixes in 10 jaar oude code, bizar. Goed gevonden!

YuenZicht commented 1 year ago

hm, dat is inderdaad wel verstandig. zal dat nog proberen deze week te doen, anders mogen jullie dit zelf oplossen ;)

YuenZicht commented 1 year ago

heads up, ik ga dit in eerdere release mergen in PR https://github.com/zicht/messages-bundle/pull/47 Ik zal vervolgens de forward merge als tags 6.0.3 and 7.1.1 uitbrengen.

Dit lijkt niet in release 4.x of eerder voor te komen.