zidhuss / neotest-minitest

Neotest adapter for Minitest
MIT License
13 stars 18 forks source link

'should' definitions not recognized. #24

Open zenom opened 2 months ago

zenom commented 2 months ago

We have some older tests that still have a 'should' syntax, this is not working with the current version.

I was able to get it to recognize 'should' syntax as a test but it would not return results. (in the query definition - https://github.com/zidhuss/neotest-minitest/blob/0543bf4e997b2c970707cb297e2f74c438eb0653/lua/neotest-minitest/init.lua#L41).

The tests always returned the red X on the results even though they passed. Showing the test output confirms they passed. I tried different reporters for minitest to no avail.

Example:

class SampleTest < ActiveSupport::TestCase
  context 'testing' do
    should 'be true' do
      assert true
    end
  end
end
dirodriguezm commented 2 months ago

For me it runs all the tests in the file even if running only one test.

zenom commented 2 months ago

For me it runs all the tests in the file even if running only one test.

With the should syntax posted above?