Closed dubisdev closed 11 months ago
This should include saving the shortcuts config somewhere so we can configure the custom shortcuts on startup.
Hi @sekwah41
I'm back with this. What do you think about renaming some of the command names? I think we can make them more descriptive.
For example:
Instead of "set_minimize" we might use "minimize_window" which I think that fits better with the things the function/commands are doing.
Other similar are: "set_show" -> "show_window", "set_close" -> "close_window"
I'm doing some small refactors to make it easier to implement the shortcuts management
Hi @sekwah41 this PR is done for now
Ill take a look after im back from visiting family :)
Edit: I'll continue with this in another PR to keep this PR atomic
For now, I started refactoring some part related to the shortcuts so the codebase can be better understanded.
To-dos
In a future PR will be included
Related issues
re #403 re #74
Also found a bug with the Undo - Redo shortcut (4a61aa0). It was using the casing of the 'z' character to determine when it should be one or the other. This caused that, if the "Mayus" was activated, doing
ctrl + Z
triggered the redo.Now the shortcuts are:
ctrl + z
to undoctrl + shift + z
to redoDiscord discussion: https://discord.com/channels/1173649313734328441/1175398470341886032