zidoro / pomatez

Stay Focused. Take a Break.
https://zidoro.github.io/pomatez/
MIT License
4.07k stars 171 forks source link

chore: improvements to create a shortcuts management system #523

Closed dubisdev closed 11 months ago

dubisdev commented 1 year ago

Edit: I'll continue with this in another PR to keep this PR atomic

For now, I started refactoring some part related to the shortcuts so the codebase can be better understanded.

To-dos

In a future PR will be included

Related issues

re #403 re #74

Also found a bug with the Undo - Redo shortcut (4a61aa0). It was using the casing of the 'z' character to determine when it should be one or the other. This caused that, if the "Mayus" was activated, doing ctrl + Z triggered the redo.

Now the shortcuts are:

Discord discussion: https://discord.com/channels/1173649313734328441/1175398470341886032

dubisdev commented 1 year ago

This should include saving the shortcuts config somewhere so we can configure the custom shortcuts on startup.

dubisdev commented 11 months ago

Hi @sekwah41

I'm back with this. What do you think about renaming some of the command names? I think we can make them more descriptive.

For example:

image image

Instead of "set_minimize" we might use "minimize_window" which I think that fits better with the things the function/commands are doing.

Other similar are: "set_show" -> "show_window", "set_close" -> "close_window"

I'm doing some small refactors to make it easier to implement the shortcuts management

dubisdev commented 11 months ago

Hi @sekwah41 this PR is done for now

sekwah41 commented 11 months ago

Ill take a look after im back from visiting family :)