search

zidoro / pomatez

Stay Focused. Take a Break.
https://zidoro.github.io/pomatez/
MIT License
4.07k stars 171 forks source link

refactor(renderer): extract common logic from Electron and Tauri connectors #591

Closed dubisdev closed 10 months ago

dubisdev commented 10 months ago

This PR includes a refactor of the Tauri and Electron connectors.

I created an AgnosticConnector component to store the common code of both components.

The idea is to introduce in the AgnosticConnector the logic to manage global shortcuts (PR incoming)

sekwah41 commented 10 months ago

My plan at least is to eventually drop electron support once we have everything ported over (and it supports everything equally) solely to reduce the amount of maintenance.

I think the only thing that would suffer from it is the portable version however windows comes with most of the stuff pre-installed it requires at least so technically you can still sorta have a portable version. Tho not to the same degree as Electron.

dubisdev commented 10 months ago

I'm closing this for now :)