zielu / GitToolBox

GitToolBox IntelliJ plugin
GNU General Public License v3.0
604 stars 71 forks source link

git blame gitmoji not showing #220

Open itspooya opened 4 years ago

itspooya commented 4 years ago

When showing git blame in IDE the gitmoji doesn't get rendered and shows as a text

zielu commented 4 years ago

Hi, I only provide completion in commit dialog.

Places where I could add display would be ones from my plugin:

Maybe places:

For Git Log and Annotate provided by IDE it needs more research.

itspooya commented 4 years ago

github Here actually :tada: shows as text and not as a emoji. I think its inline blame

zielu commented 4 years ago

Research results:

zielu commented 4 years ago

Note to self - try replacing gitmoji text with unicode for example alembic : https://emojipedia.org/emoji/⚗/

See https://blog.jetbrains.com/idea/2020/06/intellij-idea-2020-2-eap2-is-here-with-advanced-exception-stack-trace-analysis-emoji-support-on-linux-and-more/?utm_source=product&utm_medium=link&utm_campaign=TBA for reference

zielu commented 3 years ago

Possible because #268 is done

scruel commented 2 years ago

Possible because #268 is done image

No completion in Commit dialog. IDEA Version: 2021.2.3

zielu commented 2 years ago

@scruel not related - missing completion in non-modal dialog is a separate isssue.

I created #355 to track it

scruel commented 2 years ago

@scruel not related - missing completion in non-modal dialog is a separate isssue.

I created #355 to track it

Ok, I was thought that my issue may same as 'gitmoji not showing', and I noticed you mentioned you provide completion in commit dialog(https://github.com/zielu/GitToolBox/issues/220#issuecomment-599383442), so I post it here, sorry for the inconvenience!