search

zielu / GitToolBox

GitToolBox IntelliJ plugin
GNU General Public License v3.0
604 stars 73 forks source link

Cant save "Auto fetch" setting #339

Closed aliusa closed 3 years ago

aliusa commented 3 years ago

Can't save settings after I unchecked "Auto fetch" setting - "Apply" or "OK" doesn't work. GitToolBox: 212.7.7 PhpStorm: 2021.2.1 (PS-212.5080.71)

zielu commented 3 years ago

Hi, in Version Control / GitToolBox or Version Control / GitToolBox / GitToolBox Project

aliusa commented 3 years ago

Version Control -> GitToolBox all projects settings

zielu commented 3 years ago

So you uncheck Auto fetch but Apply button does not become active, correct ?

aliusa commented 3 years ago
  1. I uncheck "Auto fetch"
  2. "Apply" button becomes active (pressable/clickable)
  3. I try to press "Apply" or "OK"
  4. nothing happens
zielu commented 3 years ago

But it is disabled when you reopen configuration ? Because there is no special feedback when auto-fetch is disabled - it just stops being executed.

aliusa commented 3 years ago

It ("Auto fetch" option) is disabled when configuration is reopened. It is disabled because changes haven't been saved because of "Apply"/"OK" buttons not responding.

Tested all GitToolBox options... (global and project scope) - any change will "Apply" button to not respond. :)

Other PhpStorm options (default) is being saved ("Apply" button works).

zielu commented 3 years ago

What do you mean exactly by ""Apply" button to not respond." - it is grey out or it blocks on click. A screen recording could help.

aliusa commented 3 years ago

When I press "Apply" - it does not work (does not save settings). Here's a screenshot - when I pressed "Apply" button - it indicates (blue border) that I pressed, but it does not apply (save) settings. image

zielu commented 3 years ago

Could you gather the logs and attach them ? I suspect there might be some exception being thrown during save. See https://github.com/zielu/GitToolBox/wiki/AdvancedManual#accessing-logs

aliusa commented 3 years ago

Bug disappeared as of GitToolBox 212.7.8

WARN - com.intellij.util.xmlb.Binding - Collection PropertyAccessor(name=applied, class=zielu.gittoolbox.config.model.ExtrasBoolConfigOverride) contains 'null' object

zielu commented 3 years ago

Aha the extras config - thing is removed in 212.7.8 :)